feat(ci): deny rust warnings in all workflows #2388
Conversation
|
This change is |
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Did you test? Yoni's example could work, that is, make a Pr on top of this branch with an unused import in whatever file Yoni said was only compiled when compiling with cairo-native, with the failure expected to be at blockifier_ci's job
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/dwarnings
branch
from
58776b2 to
43fa23d
Compare
There was a problem hiding this comment.
no need for a different PR, this PR's CI fails on an unused import :)
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 13 of 14 files reviewed, all discussions resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
===========================================
+ Coverage 40.10% 72.34% +32.24%
===========================================
Files 26 101 +75
Lines 1895 13352 +11457
Branches 1895 13352 +11457
===========================================
+ Hits 760 9660 +8900
- Misses 1100 3279 +2179
- Partials 35 413 +378 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
:woo:
Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
There was a problem hiding this comment.
Reviewed 1 of 3 files at r2.
Reviewable status:
No description provided.