Skip to content

Commit

Permalink
feat(ci): deny rust warnings in all workflows
Browse files Browse the repository at this point in the history
Signed-off-by: Dori Medini <[email protected]>
  • Loading branch information
dorimedini-starkware committed Dec 2, 2024
1 parent d1ad687 commit 58776b2
Show file tree
Hide file tree
Showing 13 changed files with 35 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/blockifier_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ on:
- 'scripts/install_build_tools.sh'
- 'scripts/sequencer-ci.Dockerfile'

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/blockifier_compiled_cairo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ on:
- 'crates/blockifier/tests/requirements.txt'
- 'scripts/dependencies.sh'

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/blockifier_reexecution_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ on:
- 'scripts/install_build_tools.sh'
- 'scripts/sequencer-ci.Dockerfile'

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/committer_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ on:
- 'crates/starknet_patricia/**'
- 'scripts/dependencies.sh'

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/committer_cli_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ on:
- 'crates/starknet_patricia/**'
- 'scripts/dependencies.sh'

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:

env:
CI: 1
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/main_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
- auto_merge_enabled
- edited

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/papyrus_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ on:
merge_group:
types: [checks_requested]

env:
RUSTFLAGS: "-D warnings"

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/papyrus_docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ concurrency:
env:
REGISTRY: ghcr.io
REPO_NAME: ${{ github.repository }}
RUSTFLAGS: "-D warnings"

jobs:
docker-build-push:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/papyrus_nightly-tests-call.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ on:
SLACK_ALERT_CHANNEL:
required: true

env:
RUSTFLAGS: "-D warnings"

jobs:
GW-integration-test-call:
runs-on: ${{ inputs.os }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/papyrus_nightly-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
- cron: '30 0 * * *' # Uses macos runner.
workflow_dispatch: # Uses ubuntu runner.

env:
RUSTFLAGS: "-D warnings"

jobs:
GW-integration-test-ubuntu:
uses: ./.github/workflows/papyrus_nightly-tests-call.yml
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/upload_artifacts_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
workflows: [Trigger-Workflow]
types: [completed]

env:
RUSTFLAGS: "-D warnings"

jobs:
native-blockifier-artifacts-push:
runs-on: starkware-ubuntu-20-04-medium
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/verify-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
schedule:
- cron: '0 0 * * *' # Runs at 00:00 UTC every day

env:
RUSTFLAGS: "-D warnings"

jobs:
latest_deps:
name: Latest Dependencies
Expand Down

0 comments on commit 58776b2

Please sign in to comment.