chore: fix clippy for version 0.1.81

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

This PR is a replica of #2365 except for one difference. This PR does not include a disable of one part of the CI.

Reviewable status: 0 of 30 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 244 at r1 (raw file):

            Some(h) => h < height,
            None => true,
        } {

wonder why clippy thinks this is better

Code quote:

        if match self.current_height {
            Some(h) => h < height,
            None => true,
        } {

---

.github/workflows/papyrus_docker-publish.yml.disabled line 0 at r1 (raw file):
why was this renamed?

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-01T11:03:48Z
• Started at 2024-12-01T11:13:33Z
• Started at 2024-12-01T11:21:10Z

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

[ArniStarkware]

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 244 at r1 (raw file):

Previously, dorimedini-starkware wrote…

wonder why clippy thinks this is better

error[E0658]: use of unstable library feature 'is_none_or'
   --> crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs:274:32
    |
274 |         if self.current_height.is_none_or(|h| height > h) {

rust-lang/rust#126383

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 244 at r2 (raw file):

            Some(h) => h < height,
            None => true,
        } {

how about this?

Suggestion:

        if self.current_height.map(|h| h < height).unwrap_or(true) {

[ArniStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

.github/workflows/papyrus_docker-publish.yml.disabled line at r1 (raw file):

Previously, dorimedini-starkware wrote…

why was this renamed?

In the current revision 2 of this PR, there is no rename.
Now this PR is actually different than #2365

[ArniStarkware]

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 244 at r2 (raw file):

Previously, dorimedini-starkware wrote…

how about this?

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (e3165c4) to head (e0ff236).
Report is 638 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2371       +/-   ##
===========================================
+ Coverage   40.10%   53.98%   +13.88%     
===========================================
  Files          26      256      +230     
  Lines        1895    29247    +27352     
  Branches     1895    29247    +27352     
===========================================
+ Hits          760    15790    +15030     
- Misses       1100    12293    +11193     
- Partials       35     1164     +1129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.