-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix clippy for version 0.1.81 #2365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
===========================================
+ Coverage 40.10% 54.00% +13.89%
===========================================
Files 26 256 +230
Lines 1895 29243 +27348
Branches 1895 29243 +27348
===========================================
+ Hits 760 15792 +15032
- Misses 1100 12287 +11187
- Partials 35 1164 +1129 ☔ View full report in Codecov by Sentry. |
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
edf35a9
to
7934110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
.github/workflows/papyrus_docker-publish.yml
line 84 at r3 (raw file):
labels: ${{ steps.meta.outputs.labels }} cache-from: type=gha cache-to: type=gha,mode=max -->
blocking until reverted..
Code quote:
<!-- docker-build-push:
runs-on: starkware-ubuntu-latest-large
steps:
- name: Checkout repository
uses: actions/checkout@v4
# Not required but recommended - enables build multi-platform images, export cache, etc
# Also workaround for: https://github.com/docker/build-push-action/issues/461
# https://github.com/docker/setup-buildx-action
- name: Setup Docker buildx
uses: docker/[email protected]
# Login to a Docker registry except on PR
# https://github.com/docker/login-action
- name: Login to registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/[email protected]
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
logout: true
# Extract metadata (tags, labels) for Docker
# https://github.com/docker/metadata-action
- name: Extract Docker metadata
id: meta
uses: docker/[email protected]
with:
images: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/papyrus
tags: |
type=semver,pattern={{raw}}
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=ref,event=pr
# set `dev` tag for the default branch (`main`).
type=raw,value=dev,enable={{is_default_branch}}
type=raw,value={{branch}}{{tag}}-{{sha}},enable=${{ github.event_name == 'workflow_dispatch' }}
# Build and push Docker image with Buildx
# https://github.com/docker/build-push-action
- name: Build and push Docker image
uses: docker/[email protected]
with:
context: .
file: deployments/images/papyrus/Dockerfile
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
a discussion (no related file):
this command works locally for me:
cargo build --release --package papyrus_node
my wild guess would be: need to purge the docker cache to reinstall the rust toolchain
dunno how, or if that even makes... just a guess
b5673b6
to
b5f3eb6
Compare
This PR is a replica of #2371, except for one difference. This PR includes a disable of one part of the CI. |
No description provided.