Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tests-integration): send txs in e2e integration test #1895

Merged
merged 5 commits into from
Nov 10, 2024
Merged

test(tests-integration): send txs in e2e integration test #1895

merged 5 commits into from
Nov 10, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 9, 2024 •
edited
Loading

This was referenced Nov 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (e3165c4) to head (88838f0).
Report is 272 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1895       +/-   ##
===========================================
+ Coverage   40.10%   76.89%   +36.78%     
===========================================
  Files          26      368      +342     
  Lines        1895    39339    +37444     
  Branches     1895    39339    +37444     
===========================================
+ Hits          760    30248    +29488     
- Misses       1100     6840     +5740     
- Partials       35     2251     +2216

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

ArniStarkware
ArniStarkware approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

ArniStarkware
ArniStarkware approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

ArniStarkware
ArniStarkware approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/6769aef1 to main November 10, 2024 12:11
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit d99843e into main Nov 10, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArniStarkware ArniStarkware ArniStarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare @ArniStarkware