-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tests-integration): await until node is alive #1894
Conversation
Artifacts upload triggered. View details here |
Benchmark movements: full_committer_flow performance improved 😺 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/61787bd4 #1894 +/- ##
======================================================
+ Coverage 29.32% 76.82% +47.49%
======================================================
Files 264 368 +104
Lines 30655 39230 +8575
Branches 30655 39230 +8575
======================================================
+ Hits 8991 30137 +21146
+ Misses 20783 6834 -13949
- Partials 881 2259 +1378 ☔ View full report in Codecov by Sentry. |
466b3e0
to
f26a153
Compare
Artifacts upload triggered. View details here |
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about this keep-alive client, but I am not sure there is much to know.
Approved.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
commit-id:6769aef1
f26a153
to
4b939a7
Compare
Artifacts upload triggered. View details here |
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #1895 |
Stack: