Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tests-integration): await until node is alive #1894

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 9, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 9, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.712 ms 33.746 ms 33.782 ms]
change: [-2.6948% -2.3434% -2.0237%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

full_committer_flow performance improved 😺
full_committer_flow time: [29.256 ms 29.288 ms 29.320 ms]
change: [-5.4446% -4.7658% -4.1432%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (bad620c) to head (4b939a7).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           spr/main/61787bd4    #1894       +/-   ##
======================================================
+ Coverage              29.32%   76.82%   +47.49%     
======================================================
  Files                    264      368      +104     
  Lines                  30655    39230     +8575     
  Branches               30655    39230     +8575     
======================================================
+ Hits                    8991    30137    +21146     
+ Misses                 20783     6834    -13949     
- Partials                 881     2259     +1378     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about this keep-alive client, but I am not sure there is much to know.
Approved.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #1895

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants