Modify int_range_try_new to return an empty range on failure. #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2024
orizi
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
liorgold2
force-pushed
the
pr/liorgold2/lior/range1/dd3477ad
branch
from
66cac9c to
2cb2ace
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/range1/312d2d4b
branch
from
25aaf84 to
aa602cc
Compare
orizi
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
liorgold2
force-pushed
the
pr/liorgold2/lior/range1/dd3477ad
branch
from
2cb2ace to
d28ae43
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/range1/312d2d4b
branch
from
aa602cc to
1f7ec56
Compare
liorgold2
changed the title
orizi
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
commit-id:312d2d4b
liorgold2
changed the base branch from
pr/liorgold2/lior/range1/dd3477ad
to
main
liorgold2
force-pushed
the
pr/liorgold2/lior/range1/312d2d4b
branch
from
1f7ec56 to
8bd1702
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is