Add int_range_try_new libfunc.

[liorgold2]

Stack:

• Modify int_range_try_new to return an empty range on failure. #6298
• Use IntRange libfuncs in range.cairo. #6289
• Add int_range_try_new libfunc. #6288 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[liorgold2]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/range.rs line 120 at r1 (raw file):

                },
                // Failure.
                BranchSignature {

I wonder if I should return the range [y, y] in the failure branch. Currently, the high level code looks like:

        match internal::range_try_new(self.start, self.end) {
            Option::Some(range) => range,
            Option::None => internal::range_try_new(self.end, self.end).unwrap(),
        }

Note the unwrap() which makes it panicable (unnecessarily).

The two ways to solve it (if we want to) are:

1. Return the range [y, y] on failure.
2. Add another libfunc for constructing an empty range [a, a] (which never fails)

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @liorgold2)

---

crates/cairo-lang-sierra/src/extensions/modules/range.rs line 120 at r1 (raw file):

Previously, liorgold2 wrote…

I wonder if I should return the range [y, y] in the failure branch. Currently, the high level code looks like:

        match internal::range_try_new(self.start, self.end) {
            Option::Some(range) => range,
            Option::None => internal::range_try_new(self.end, self.end).unwrap(),
        }

Note the unwrap() which makes it panicable (unnecessarily).

The two ways to solve it (if we want to) are:

1. Return the range [y, y] on failure.
2. Add another libfunc for constructing an empty range [a, a] (which never fails)

making Range constable makes sense as well.

but returning it in the Result::Err makes sense to me (as it actually costs nothing).

but if we add it as constable we can than just (One::one(), One::one()) or something like it.

[orizi]

Reviewed 4 of 5 files at r3, all commit messages.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @liorgold2)

[liorgold2]

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/range.rs line 120 at r1 (raw file):

Previously, orizi wrote…

making Range constable makes sense as well.

but returning it in the Result::Err makes sense to me (as it actually costs nothing).

but if we add it as constable we can than just (One::one(), One::one()) or something like it.

I went with returning [y, y) or failure as this is the simplest solution.
Done in another PR.

[orizi]

Reviewed 1 of 5 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)