Include error ID in the error response for new error format #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Operation Attempt work
amorton
changed the title
amorton
force-pushed
the
ajm/include-error-id-in-response
branch
from
be1bb8a
to
adc748c
Compare
maheshrajamani
approved these changes
Sep 26, 2024
| @@ -61,6 +61,7 @@ public CommandResult.Error apply(APIException apiException) { | |||
| errorFields.put(ErrorObjectV2Constants.Fields.FAMILY, apiException.family.name()); | |||
| errorFields.put(ErrorObjectV2Constants.Fields.SCOPE, apiException.scope); | |||
| errorFields.put(ErrorObjectV2Constants.Fields.TITLE, apiException.title); | |||
| errorFields.put(ErrorObjectV2Constants.Fields.ID, apiException.errorId); | |||
There was a problem hiding this comment.
java doc to describe what these fields are.
There was a problem hiding this comment.
there is a whole bunch of docs on the ApiException that explains all the fields, your comment has reminded me that it's about time we refactor the CommandResult.Error it is a mess with the map.
if we do this, then we dont need all these fields and maps etc see #1462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already happening for the old errors mapped to new, the new OperationAttempt work relies on this
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist