Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactor: CommandResult.Error needs real fields not a map #1462

Open
amorton opened this issue Sep 26, 2024 · 1 comment
Open

code refactor: CommandResult.Error needs real fields not a map #1462

amorton opened this issue Sep 26, 2024 · 1 comment
Assignees

Comments

@amorton
Copy link
Contributor

amorton commented Sep 26, 2024

after the work in #1454

it's clear now we have a better view on what an error should be, from Error Object v2 work, and the CommandResult.Error is a hot mess with a map of values that is expeded by jackson

  • refactor so we have fields on the record for all the expected fields of an error object
  • work out how to have the JSON serialisation ignore that fields that are either not set, or we dont want to send. The hard part will be that the "scope" field is optional for error object v2. But maybe we just make sure Jackson excludes fields that are null, and we make sure to set scope to empty string (which I think already happens)

this will have a wide impact in the code base

@amorton
Copy link
Contributor Author

amorton commented Oct 10, 2024

Partially addessed in #1447

it adds CommandErrorV2 class that is used for the warnings, this ticket is now to change the code for errors to use that class and its CommndError (v1) parent whenneeded.

@amorton amorton self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant