Skip to content

Remove all driver related files #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented May 13, 2025

Description

Kernel modules and eBPF probes (collectively known as "drivers"), have been deprecated for quite some time and the last versions that still supported them have reached EOL. As such, we shouldn't have to update them anymore.

This PR gets rid of all the leftover scripts that downloaded drivers, uploaded them to GCP, packaged them as support-packages, uploaded those to GCP, created the index for the CDN page, etc.

We also remove the RELEASED_VERSIONS, RELEASED_VERSIONS.unsupported and KERNEL_VERSIONS files, these were only used for driver and support-package related tasks and are now pointless. Correlating versions between stackrox and collector can be achieved using the following command in the main repo:
git show <tag>:COLLECTOR_VERSION

I will add that command to our documentation as part of a separate doc cleanup PR (I think this one is large enough as is).

Checklist

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be enough.

These files are used to correlate collector versions to stackrox
versions, main use for it was to create the index directory for
support-packages.

Since support-packages have been deprecated since 4.4, there's not much
point in keeping these files updated anymore and the only purpose it
seems to serve is taking up release engineers time ping-ponging a PR
that gets a rubber-stamped "approved" and merge from the collector team.
Hence, we are removing the files from the collector repo altogether.

Correlating versions between stackrox and collector can be achieved
using the following command in the main repo:
  `git show <tag>:COLLECTOR_VERSION`

I will add that command to our documentation as part of a larger
cleanup.
@Molter73 Molter73 requested a review from a team as a code owner May 13, 2025 16:18
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Molter73 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.52%. Comparing base (0af861a) to head (5310899).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2124   +/-   ##
=======================================
  Coverage   28.52%   28.52%           
=======================================
  Files          94       94           
  Lines        5757     5757           
  Branches     2547     2547           
=======================================
  Hits         1642     1642           
  Misses       3393     3393           
  Partials      722      722           
Flag Coverage Δ
collector-unit-tests 28.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And by extension all scripts, files and actions related to drivers.
@Molter73 Molter73 changed the title Remove RELEASED_VERSIONS and RELEASED_VERSIONS.unsupported Remove all driver related files May 14, 2025
@Molter73 Molter73 added the run-cpaas-steps Trigger CI steps related to cPaaS label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-cpaas-steps Trigger CI steps related to cPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants