-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise validation error for all zero response data #68
Conversation
222d91d
to
a7fecf0
Compare
Any way we could get some movement on this? happy to contribute, this has been broken for over a year now and it is bugging me :) |
7a38b02
to
96576d5
Compare
Reworked based on current master. |
Hi VK, thanks for the push! Quick question: do you know the version/build when it will hit GA? |
Hey @joseal, that depends on @squishykid. He might have different plans about his issue :) |
@squishykid , any concern? This issue is disturbing a ton of people for a year... it was great if it could be fixed. Thank you. |
Any news about this issue? I still need to be constantly manual fixing the values... |
Hi @squishykid any news? |
Thanks for the reminder! I will also cut a new release, so it can be updated in home-assistant |
Brilliant! Thank you very much. |
This reverts commit 2c20404.
* update actions to latest major version Signed-off-by: Robin Wohlers-Reichel <[email protected]> * Revert "raise validation error for all zero response data (#68)" This reverts commit 2c20404. --------- Signed-off-by: Robin Wohlers-Reichel <[email protected]>
@joseal can you please take another look at this? I think CI was broken, but I had to revert this commit because it broke discovery |
If I'm not wrong, this change was made by @VadimKraus... VK, could you please check it? Thank you! |
The discovery error is unrelated to this change. |
Did some testing: the discovery has been in this broken state since a7a95f7. This causes a race condition where 'solax.inverters.x1_boost.X1Boost' and 'solax.inverters.x1_mini_v34.X1MiniV34' are being confused with each other. They have basically an overlapping schema... @squishykid I will reopen this PR, since the problem is unrelated. However, the discovery needs to be fixed ... |
This is a possible solution for #67.
After this PR:
Consequences for Home assistant:
If an zeros data event occurs, the validation error will cause the sensor update to fail and thereby the inherent home assistant retry will be triggered. No Changes to the solax integration are required.