Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery non deterministic results #143

Open
VadimKraus opened this issue Mar 10, 2024 · 0 comments
Open

Discovery non deterministic results #143

VadimKraus opened this issue Mar 10, 2024 · 0 comments

Comments

@VadimKraus
Copy link
Contributor

As discussed in #68, the discovery test will occasionally fail.
This may result in an incorrect discovery. This issue is mainly related to following inverters and their similar schema:

<class 'solax.inverters.x1_boost.X1Boost'>
<class 'solax.inverters.x1_mini_v34.X1MiniV34'>

Steps to reproduce:

pytest --count=10 tests/test_discovery.py::test_discovery

Actual result:

============================================== short test summary info ==============================================
FAILED tests/test_discovery.py::test_discovery[inverters_fixture4-1-10] - AssertionError: assert <class 'solax.inverters.x1_boost.X1Boost'> == <class 'solax.inverters.x1_mini_v34.X1MiniV34'>
FAILED tests/test_discovery.py::test_discovery[inverters_fixture4-2-10] - AssertionError: assert <class 'solax.inverters.x1_boost.X1Boost'> == <class 'solax.inverters.x1_mini_v34.X1MiniV34'>
FAILED tests/test_discovery.py::test_discovery[inverters_fixture4-6-10] - AssertionError: assert <class 'solax.inverters.x1_boost.X1Boost'> == <class 'solax.inverters.x1_mini_v34.X1MiniV34'>
FAILED tests/test_discovery.py::test_discovery[inverters_fixture4-9-10] - AssertionError: assert <class 'solax.inverters.x1_boost.X1Boost'> == <class 'solax.inverters.x1_mini_v34.X1MiniV34'>
===================================== 4 failed, 196 passed in 101.80s (0:01:41) =====================================

Expected result: No test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant