Track ktlint's code styles #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation indent is now 2 instead of 4.
|
already in conflict 🙀 |
oldergod
approved these changes
Sep 29, 2020
vRallev
reviewed
Sep 29, 2020
| <option name="METHOD_ANNOTATION_WRAP" value="1" /> | ||
| <option name="FIELD_ANNOTATION_WRAP" value="1" /> | ||
| <option name="ENUM_CONSTANTS_WRAP" value="2" /> | ||
| <indentOptions> | ||
| <option name="INDENT_SIZE" value="2" /> | ||
| <option name="CONTINUATION_INDENT_SIZE" value="4" /> | ||
| <option name="CONTINUATION_INDENT_SIZE" value="2" /> |
There was a problem hiding this comment.
That would have a big impact on many other codebases. We'd basically need to reformat all of them. What's the motivation?
There was a problem hiding this comment.
If your concern is only KtLint, then there's an open ticket to bring back the continuation indent: pinterest/ktlint#816
|
Change |
|
Retracted my 👎 . Chatted offline, and realized that we can put a tag on the current commit to give ourselves control over rolling this out across our code base. Bonus points if you go ahead and make that tag for us all. |
|
I’m gonna hold on this until we can roll forward with something that’s less invasive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation indent is now 2 instead of 4.