Track KtLint's code styles. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
commented
Nov 12, 2020
| @@ -257,7 +260,7 @@ | |||
| <option name="ALLOW_TRAILING_COMMA" value="true" /> | |||
| <indentOptions> | |||
| <option name="INDENT_SIZE" value="2" /> | |||
| <option name="CONTINUATION_INDENT_SIZE" value="4" /> | |||
| <option name="CONTINUATION_INDENT_SIZE" value="2" /> | |||
There was a problem hiding this comment.
We'll need to reformat the Register Android codebase. I'll take care of this (that was the main concern why #82 was declined). Cash Android should already use a 2 space continuation indent.
vRallev
commented
Nov 12, 2020
| <option name="ALIGN_MULTILINE_PARAMETERS" value="false" /> | ||
| <option name="CALL_PARAMETERS_WRAP" value="1" /> | ||
| <option name="CALL_PARAMETERS_LPAREN_ON_NEXT_LINE" value="true" /> | ||
| <option name="CALL_PARAMETERS_RPAREN_ON_NEXT_LINE" value="true" /> | ||
| <option name="METHOD_PARAMETERS_WRAP" value="5" /> |
There was a problem hiding this comment.
The codestyle for Kotlin of Square and SquareAndroid are now identical except for this value. I didn't want to change it.
vRallev
requested review from
zach-klippenstein,
swankjesse,
rjrjr and
JakeWharton
zach-klippenstein
approved these changes
Nov 12, 2020
swankjesse
approved these changes
Nov 12, 2020
|
Gotta figure out a strategy to fix ~200 cash repos when we land this. |
pyricau
added a commit
to square/leakcanary
that referenced
this pull request
Dec 4, 2020
Follows latest Square formatting rules: square/java-code-styles#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically reopening #82. I merged the settings that IntelliJ and KtLint export.