Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update Codicons update command and assets #259

Merged
merged 5 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ The following prefixes are currently available to use:

- `ri` prefix holds [**Remix Icon** 2.5.0 with its 2271 icons.](https://github.com/Remix-Design/RemixIcon)

- `msc` prefix holds Microsoft's [**Codicons** 0.0.35 with its 446 icons.](https://github.com/microsoft/vscode-codicons)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that the version is the same but the number of icons is different? Shouldn't the version number be greater than 0.0.35?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is caused due to the change from the .csv to the .css file as source to generate the icons charmap file. As mentioned at #241 (comment) the .csv misses icons definitions available from the .css file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then it's really good that our asset files are going to be versioned since our next release.

- `msc` prefix holds Microsoft's [**Codicons** 0.0.35 with its 540 icons.](https://github.com/microsoft/vscode-codicons)

### Examples

Expand Down
2 changes: 1 addition & 1 deletion UPDATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ To update _Codicons_ icons, one must:
- check what is the latest released version here: https://github.com/microsoft/vscode-codicons/releases
- update font version in \_\_init__.py
- remove outdated files in the fonts dir
- run: `python setup.py update_msc`
- run: `python setup.py update_msc --msc-version X.X.X`
- update Codicons version number, icon counts and URLs inside:
- README.md
- qtawesome/docs/source/usage.rst
1 change: 1 addition & 0 deletions docs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ dependencies:
- pyqt
- qtpy
- sphinx_rtd_theme
- pip
4 changes: 2 additions & 2 deletions docs/source/usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ The following prefixes are currently available to use:

- ``ri`` prefix holds `Remix Icon 2.5.0 with its 2271 icons.`_

- ``msc`` prefix holds Microsoft's `Codicons 0.0.35 with its 446 icons.`_
- ``msc`` prefix holds Microsoft's `Codicons 0.0.35 with its 540 icons.`_

.. _FontAwesome: https://fontawesome.com
.. _151 icons in the "regular" style.: https://fontawesome.com/v5/search?o=r&m=free&s=regular
Expand All @@ -45,7 +45,7 @@ The following prefixes are currently available to use:
.. _Material Design Icons 5.9.55 with its 5955 icons.: https://cdn.materialdesignicons.com/5.9.55/
.. _Phosphor 1.3.0 with its 4470 icons (894 icons * 5 weights\: Thin, Light, Regular, Bold and Fill).: https://github.com/phosphor-icons/phosphor-icons
.. _Remix Icon 2.5.0 with its 2271 icons.: https://github.com/Remix-Design/RemixIcon
.. _Codicons 0.0.35 with its 446 icons.: https://github.com/microsoft/vscode-codicons
.. _Codicons 0.0.35 with its 540 icons.: https://github.com/microsoft/vscode-codicons

Examples
~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion qtawesome/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
'materialdesignicons6-webfont-6.9.96.ttf': 'ecaabfbb23fdac4ddbaf897b97257a92',
'phosphor-1.3.0.ttf': '5b8dc57388b2d86243566b996cc3a789',
'remixicon-2.5.0.ttf': '888e61f04316f10bddfff7bee10c6dd0',
'codicon-0.0.35.ttf': '2b89de3354b7768e193c0ec14571422b',
'codicon-0.0.35.ttf': '8478f5b3df2158f7e4864473e34efda1',
}


Expand Down
Binary file modified qtawesome/fonts/codicon-0.0.35.ttf
Binary file not shown.
Loading
Loading