PR: Update Codicons update command and assets #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
ccordoba12
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Some stylistic questions and an important question for you @dalthviz.
| @@ -71,7 +71,7 @@ The following prefixes are currently available to use: | |||
|
|
|||
| - `ri` prefix holds [**Remix Icon** 2.5.0 with its 2271 icons.](https://github.com/Remix-Design/RemixIcon) | |||
|
|
|||
| - `msc` prefix holds Microsoft's [**Codicons** 0.0.35 with its 446 icons.](https://github.com/microsoft/vscode-codicons) | |||
There was a problem hiding this comment.
How is that the version is the same but the number of icons is different? Shouldn't the version number be greater than 0.0.35?
There was a problem hiding this comment.
I think this is caused due to the change from the .csv to the .css file as source to generate the icons charmap file. As mentioned at #241 (comment) the .csv misses icons definitions available from the .css file.
There was a problem hiding this comment.
Ok, then it's really good that our asset files are going to be versioned since our next release.
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
approved these changes
Mar 27, 2024
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
.cssinstead of.csvfile to build charmap--msc-versionarg to the command and use it to build the download URLs (.ttf, .css and .json files)Fixes #252