Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit 4 -> 5 #5899

Closed
wants to merge 9 commits into from
Closed

JUnit 4 -> 5 #5899

wants to merge 9 commits into from

Commits on Aug 21, 2024

  1. Remove .jdk8 files. (spring-cloud#5900)

    @corneil
    corneil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8714a0a View commit details
    Browse the repository at this point in the history

  2. Update SCDF so that multipleComposedTaskWithArguments succeeds 

    Step 1. Make sure to remove the version from the docker compose.  It is no longer needed and causes older versions of docker to fail
Step 2. Update compose files to use the latest version of SCDF 3.x instead of 2.11.x
Step 3. Update build image script so that uses java 17 when creating containers

Update the DataFlowIT and the Abstract classes it is built on so that multipleComposedTaskWithArguments test passes.

Notice that JobParameterJacksonDeserializer and JobParametersJacksonMixIn have been updated.  These changes mirror those in spring-cloud#5850.   These were required for the test to pass.  At the time this PR is merged we can merge accepting those from spring-cloud#5850.

Provide docs on how SCDF images are created and pushed

Also update the DEFAULT_JDK to Java 17

Update PR based on code review comments

* Added log message in case a JobParameter Type is invalid
* cleaned up workflow.adoc
    @cppwfs @corneil
    cppwfs authored and corneil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    08ca0dd View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'main-3' into corneil/main3-junit5

    @corneil
    corneil authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6cad8f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Update ci-pr to record failed tests.

    @corneil
    corneil committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5e7fa1b View commit details
    Browse the repository at this point in the history

  2. Updated missed changes from main-3.

    @corneil
    corneil committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    59cee87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main-3' into corneil/main3-junit5

    @corneil
    corneil authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    89f4e6f View commit details
    Browse the repository at this point in the history

  4. Secrets are not available to PR build. 

    Remove docker login and full profile.
    @corneil
    corneil committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b1ac63f View commit details
    Browse the repository at this point in the history

  5. Remove plugin that doesn't have permission to produce integration tests.

    @corneil
    corneil committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    788a426 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Updated assertj usage.

    @corneil
    corneil committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b48ef32 View commit details
    Browse the repository at this point in the history