JUnit 4 -> 5 #5899
Open
JUnit 4 -> 5 #5899
+23
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneil
force-pushed
the
corneil/main3-junit5
branch
from
f31ecf0
to
6939d6a
Compare
|
Only one remaining test remains |
Step 1. Make sure to remove the version from the docker compose. It is no longer needed and causes older versions of docker to fail Step 2. Update compose files to use the latest version of SCDF 3.x instead of 2.11.x Step 3. Update build image script so that uses java 17 when creating containers Update the DataFlowIT and the Abstract classes it is built on so that multipleComposedTaskWithArguments test passes. Notice that JobParameterJacksonDeserializer and JobParametersJacksonMixIn have been updated. These changes mirror those in spring-cloud#5850. These were required for the test to pass. At the time this PR is merged we can merge accepting those from spring-cloud#5850. Provide docs on how SCDF images are created and pushed Also update the DEFAULT_JDK to Java 17 Update PR based on code review comments * Added log message in case a JobParameter Type is invalid * cleaned up workflow.adoc
corneil
force-pushed
the
corneil/main3-junit5
branch
from
0aafc8c
to
59cee87
Compare
cppwfs
requested changes
Sep 3, 2024
| with: | ||
| maven-version: 3.8.8 | ||
| maven-mirror: 'https://dlcdn.apache.org/maven/maven-3/' | ||
| # secrets not available to PR. | ||
| # - name: Login dockerhub | ||
| # if: ${{ secrets.DOCKERHUB_USERNAME != null && secrets.DOCKERHUB_USERNAME != '' }} | ||
| # uses: docker/login-action@v3 |
There was a problem hiding this comment.
Can we remove this commented out code?
| @@ -717,6 +717,7 @@ void pagination() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
|
|
|||
There was a problem hiding this comment.
I think this is an artifact. But we can probably remove these blank lines between the @test and the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all module except spring-cloud-dataflow-common-test-docker to JUnit 5.
Converted JUnit Asserts to AssertJ
Remove all Hamcrest matchers except those required by mockMvc assertions. Disabled failing tests for further investigation.
Resolves #5914