Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataFlowIT.multipleComposedTaskWithArguments so that it will pass #5898

Closed
wants to merge 4 commits into from
Closed

Update DataFlowIT.multipleComposedTaskWithArguments so that it will pass #5898

wants to merge 4 commits into from

Commits on Aug 19, 2024

  1. Update SCDF so that multipleComposedTaskWithArguments succeeds 

    Step 1. Make sure to remove the version from the docker compose.  It is no longer needed and causes older versions of docker to fail
Step 2. Update compose files to use the latest version of SCDF 3.x instead of 2.11.x
Step 3. Update build image script so that uses java 17 when creating containers
    @cppwfs
    cppwfs committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e176d3c View commit details
    Browse the repository at this point in the history

  2. Update the DataFlowIT and the Abstract classes it is built on so that… 

    … multipleComposedTaskWithArguments test passes.

Notice that JobParameterJacksonDeserializer and JobParametersJacksonMixIn have been updated.  These changes mirror those in spring-cloud#5850.   These were required for the test to pass.  At the time this PR is merged we can merge accepting those from spring-cloud#5850.
    @cppwfs
    cppwfs committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    37c763f View commit details
    Browse the repository at this point in the history

  3. Provide docs on how SCDF images are created and pushed 

    Also update the DEFAULT_JDK to Java 17
    @cppwfs
    cppwfs committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3cf939b View commit details
    Browse the repository at this point in the history

  4. Update PR based on code review comments 

    * Added log message in case a JobParameter Type is invalid
* cleaned up workflow.adoc
    @cppwfs
    cppwfs committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1119e55 View commit details
    Browse the repository at this point in the history