Update DataFlowIT.multipleComposedTaskWithArguments so that it will pass #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
changed the title
onobc
reviewed
Aug 16, 2024
onobc
reviewed
Aug 16, 2024
onobc
reviewed
Aug 16, 2024
onobc
reviewed
Aug 16, 2024
...org/springframework/cloud/dataflow/rest/support/jackson/JobParameterJacksonDeserializer.java
Show resolved
Hide resolved
onobc
reviewed
Aug 16, 2024
.../java/org/springframework/cloud/dataflow/rest/support/jackson/JobParametersJacksonMixIn.java
Outdated
Show resolved
Hide resolved
Step 1. Make sure to remove the version from the docker compose. It is no longer needed and causes older versions of docker to fail Step 2. Update compose files to use the latest version of SCDF 3.x instead of 2.11.x Step 3. Update build image script so that uses java 17 when creating containers
… multipleComposedTaskWithArguments test passes. Notice that JobParameterJacksonDeserializer and JobParametersJacksonMixIn have been updated. These changes mirror those in spring-cloud#5850. These were required for the test to pass. At the time this PR is merged we can merge accepting those from spring-cloud#5850.
Also update the DEFAULT_JDK to Java 17
* Added log message in case a JobParameter Type is invalid * cleaned up workflow.adoc
cppwfs
force-pushed
the
SCDF-CTR-AT-UPDATE2
branch
from
30844e7
to
1119e55
Compare
|
Squashed rebased Merged. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 commits:
a. Make sure to remove the
versionfrom the docker-compose.yml files. It is marked as obsolete and causes different versions ofdocker composeto fail.b. Update docker-compose files to use the latest version of SCDF 3.x instead of 2.11.x
c. Update build image script so that it uses java 17 when creating containers
Disabled flags and TODOsa. Note that some code in the is already in PR Serialize Job Parameters to the command Line Arguments on Job Restarts per Batch Standards #5850 (
JobParametersJacksonMixIn.java&DefaultTaskJobService.java). This was added so we could provide a successful test. And these changes can be removed on merge once that PR has been merged.