Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle search from left if we are searching for a value between fill and last patch in SparseArray #2609

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

robert3005
Copy link
Member

No description provided.

@robert3005 robert3005 enabled auto-merge (squash) March 6, 2025 02:07
@robert3005 robert3005 mentioned this pull request Mar 6, 2025
Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #2609 will degrade performances by 19.58%

Comparing rk/sparsesearch (3fa897f) with develop (8ba5f27)

Summary

⚡ 42 improvements
❌ 4 regressions
✅ 729 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
chunked_dict_fsst_into_canonical[(1000, 1000, 10)] 1.3 ms 1.2 ms +10.06%
chunked_dict_primitive_into_canonical[f32, (1000, 10, 10)] 186.4 µs 86.6 µs ×2.2
chunked_dict_primitive_into_canonical[f32, (1000, 10, 100)] 1,593.1 µs 717.1 µs ×2.2
chunked_dict_primitive_into_canonical[f32, (1000, 100, 10)] 186.1 µs 88.5 µs ×2.1
chunked_dict_primitive_into_canonical[f32, (1000, 100, 100)] 1,628.5 µs 733.4 µs ×2.2
chunked_dict_primitive_into_canonical[f32, (1000, 1000, 10)] 205.6 µs 105 µs +95.7%
chunked_dict_primitive_into_canonical[f32, (1000, 1000, 100)] 1,779.2 µs 896.6 µs +98.44%
chunked_dict_primitive_into_canonical[f64, (1000, 10, 10)] 212.2 µs 105.1 µs ×2
chunked_dict_primitive_into_canonical[f64, (1000, 10, 100)] 1,849.1 µs 901.2 µs ×2.1
chunked_dict_primitive_into_canonical[f64, (1000, 100, 10)] 215.9 µs 108.4 µs +99.16%
chunked_dict_primitive_into_canonical[f64, (1000, 100, 100)] 1,903.9 µs 933.5 µs ×2
chunked_dict_primitive_into_canonical[f64, (1000, 1000, 10)] 250.2 µs 141.1 µs +77.25%
chunked_dict_primitive_into_canonical[f64, (1000, 1000, 100)] 2.2 ms 1.3 ms +75.79%
chunked_dict_primitive_into_canonical[u32, (1000, 10, 10)] 184.1 µs 86.5 µs ×2.1
chunked_dict_primitive_into_canonical[u32, (1000, 10, 100)] 1,611.1 µs 717.3 µs ×2.2
chunked_dict_primitive_into_canonical[u32, (1000, 100, 10)] 188.1 µs 88.2 µs ×2.1
chunked_dict_primitive_into_canonical[u32, (1000, 100, 100)] 1,627.7 µs 733.3 µs ×2.2
chunked_dict_primitive_into_canonical[u32, (1000, 1000, 10)] 206.2 µs 104.7 µs +96.96%
chunked_dict_primitive_into_canonical[u32, (1000, 1000, 100)] 1,778.5 µs 896.4 µs +98.41%
chunked_dict_primitive_into_canonical[u64, (1000, 10, 10)] 217.1 µs 105 µs ×2.1
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@robert3005 robert3005 disabled auto-merge March 10, 2025 16:24
@robert3005 robert3005 merged commit 8ae0877 into develop Mar 10, 2025
26 of 27 checks passed
@robert3005 robert3005 deleted the rk/sparsesearch branch March 10, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant