comment

robert3005 · robert3005 · commit 1a497db80e1f · 2025-03-07T10:49:08.000Z
diff --git a/encodings/sparse/src/compute/search_sorted.rs b/encodings/sparse/src/compute/search_sorted.rs
@@ -52,8 +52,9 @@ impl SearchSortedFn<&SparseArray> for SparseEncoding {
     }
 }
 
+// Find the fill position relative to patches, in case of fill being in between patches we want to find the right most
+// index of the fill relative to patches.
 fn fill_position(array: &SparseArray, side: SearchSortedSide) -> VortexResult<usize> {
-    // In not found case we need to find the relative position of fill value to the patches
     let fill_result = if array.fill_scalar().is_null() {
         // For null fill the patches can only ever be after the fill
         SearchResult::NotFound(array.patches().min_index()?)

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,9 @@ impl SearchSortedFn<&SparseArray> for SparseEncoding {`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
	`55`	`+// Find the fill position relative to patches, in case of fill being in between patches we want to find the right most`
	`56`	`+// index of the fill relative to patches.`
`55`	`57`	`fn fill_position(array: &SparseArray, side: SearchSortedSide) -> VortexResult<usize> {`
`56`		`- // In not found case we need to find the relative position of fill value to the patches`
`57`	`58`	`let fill_result = if array.fill_scalar().is_null() {`
`58`	`59`	`// For null fill the patches can only ever be after the fill`
`59`	`60`	`SearchResult::NotFound(array.patches().min_index()?)`