Spin Factors #2519

lann · 2024-05-20T14:05:40Z

ref #2518

This has been turned into the factors branch

crates/core/src/lib.rs

crates/factor-outbound-networking/src/lib.rs

rylev · 2024-06-04T12:35:12Z

crates/factor-outbound-networking/src/lib.rs

+            .component_allowed_hosts
+            .get(ctx.app_component().id())
+            .cloned()
+            .context("missing component allowed hosts")?;


This error message is a bit weak. Perhaps:

Suggested change

.context("missing component allowed hosts")?;

.with_context(|| format!("missing allowed outbound hosts configuration for component {}", ctx.app_component().id()))?;

crates/factor-outbound-networking/src/lib.rs

crates/factor-wasi/src/lib.rs

crates/factors/src/lib.rs

crates/factors/src/factor.rs

crates/factor-wasi/src/lib.rs

crates/factors/src/spin_factors.rs

crates/factors/src/runtime_config.rs

crates/factors/src/factor.rs

crates/factor-outbound-networking/src/lib.rs

crates/factors/src/factor.rs

crates/factor-variables/src/provider_type.rs

rylev · 2024-06-10T09:14:29Z

crates/factors/src/prepare.rs

+    }
+}
+
+pub trait SelfInstanceBuilder: 'static {}


This and DefaultInstanceBuilder are nice, but I'm not convinced they're worth it. It seems like they might make things harder to understand in order to save a few lines of boilerplate...

crates/factors/src/runtime_factors.rs

lann · 2024-06-10T15:12:27Z

crates/factors/src/factor.rs

+    /// The default implementation returns an empty schema, which accepts any
+    /// configuration.
+    fn runtime_config_json_schema(&self) -> impl serde::Serialize {
+        HashMap::<(), ()>::new()


This is somewhat of a placeholder for now, thinking about how to support #2529 (comment)

crates/factors/src/runtime_factors.rs

lann · 2024-06-12T16:27:32Z

crates/factors/src/runtime_factors.rs

+// TODO: This seems fine, but then again I don't understand why `FieldOffset`'s
+// own `Sync`ness depends on `U`...
+unsafe impl<T: RuntimeFactors, F1: Factor, F2: Factor> Sync for StateGetter2<T, F1, F2> {}


A little spooky, but less spooky than what I had before...

Does this need to stay here? If so, can you try rewriting the comment as to why this is actually safe to do?

I have a fork of field-offset that fixes it, but I'm not sure that anyone is actually maintaining upstream 😬.

If that PR doesn't get merged I'm not sure I even want to keep the dependency...

crates/factors-derive/src/lib.rs

Signed-off-by: Lann Martin <[email protected]>

And shorten some generic params. Signed-off-by: Lann Martin <[email protected]>

Signed-off-by: Lann Martin <[email protected]>

Also address a bunch of feedback. Signed-off-by: Lann Martin <[email protected]>

Signed-off-by: Lann Martin <[email protected]>

Also sneak in Factor::runtime_config_json_schema Signed-off-by: Lann Martin <[email protected]>

Signed-off-by: Lann Martin <[email protected]>

lann · 2024-06-25T18:28:08Z

Closing this in favor of working on the factors branch.

lann mentioned this pull request May 21, 2024

Spin Factors SIP #2518

Merged

lann force-pushed the factors branch 3 times, most recently from 86f4bb7 to f1dc5ed Compare May 23, 2024 13:03

lann force-pushed the factors branch from b84f77f to f610ec6 Compare June 3, 2024 16:14

rylev reviewed Jun 4, 2024

View reviewed changes

rylev reviewed Jun 5, 2024

View reviewed changes

rylev reviewed Jun 7, 2024

View reviewed changes

crates/factors/src/factor.rs Outdated Show resolved Hide resolved

crates/factors/src/factor.rs Outdated Show resolved Hide resolved

crates/factors/src/factor.rs Outdated Show resolved Hide resolved

crates/factors/src/factor.rs Outdated Show resolved Hide resolved

lann force-pushed the factors branch from a5be415 to b194e29 Compare June 7, 2024 21:01

rylev reviewed Jun 10, 2024

View reviewed changes

lann commented Jun 10, 2024

View reviewed changes

lann commented Jun 11, 2024

View reviewed changes

crates/factors/src/runtime_factors.rs Outdated Show resolved Hide resolved

lann commented Jun 12, 2024

View reviewed changes

lann mentioned this pull request Jun 12, 2024

Deprecate execution of "uncomponentizable" WAGI modules #2552

Closed

rylev reviewed Jun 13, 2024

View reviewed changes

crates/factors-derive/src/lib.rs Outdated Show resolved Hide resolved

lann force-pushed the factors branch 2 times, most recently from eeeb140 to 6fbd5b7 Compare June 20, 2024 21:03

lann added 13 commits June 25, 2024 14:25

Add Spin Factors crates

a8f191b

Signed-off-by: Lann Martin <[email protected]>

factors: Naming updates

84b5007

Signed-off-by: Lann Martin <[email protected]>

factors: Fix derive macro

c5c2e61

Signed-off-by: Lann Martin <[email protected]>

factors: trait InstancePreparer -> FactorInstancePreparer

8cf5e54

Signed-off-by: Lann Martin <[email protected]>

factors: Merge InitContext and ModuleInitContext

6930507

Signed-off-by: Lann Martin <[email protected]>

factors: Add comments

2f580a9

Signed-off-by: Lann Martin <[email protected]>

factors: Add configure_app hook

d0ea626

Signed-off-by: Lann Martin <[email protected]>

VariablesFactor wip

a081459

Signed-off-by: Lann Martin <[email protected]>

factors: Reorganize spin-factors

e539cf6

Signed-off-by: Lann Martin <[email protected]>

factors: Rename SpinFactors->RuntimeFactors

5985dcb

And shorten some generic params. Signed-off-by: Lann Martin <[email protected]>

factors: Merge FactorInstancePreparer trait into Factor

b774ac0

Signed-off-by: Lann Martin <[email protected]>

factors: Add RuntimeConfig

14f3241

Also address a bunch of feedback. Signed-off-by: Lann Martin <[email protected]>

factors: Make Factor::configure_app required

9014ec6

Signed-off-by: Lann Martin <[email protected]>

lann added 9 commits June 25, 2024 14:25

factors: Add VariablesFactor runtime config

f43b2f4

Signed-off-by: Lann Martin <[email protected]>

factors: Rename VariablesProviderType -> MakeVariablesProvider

b5ec51c

Also sneak in Factor::runtime_config_json_schema Signed-off-by: Lann Martin <[email protected]>

factors: Rename MakeVariablesProvider::TYPE -> RUNTIME_CONFIG_TYPE

a33c964

Signed-off-by: Lann Martin <[email protected]>

factors: ProviderMaker -> ProviderFromToml

a3c48ae

Signed-off-by: Lann Martin <[email protected]>

factors: Add OutboundHttpFactor

2cd9a67

Signed-off-by: Lann Martin <[email protected]>

factors: Add KeyValueFactor

647b1f5

Signed-off-by: Lann Martin <[email protected]>

factors: Replace some transmute with Any::downcast_*

6668cb8

Signed-off-by: Lann Martin <[email protected]>

factors: Tweak Factor::prepare signature

d281f4a

Signed-off-by: Lann Martin <[email protected]>

factors: Remove module code

87d8f4c

Signed-off-by: Lann Martin <[email protected]>

lann force-pushed the factors branch from 6fbd5b7 to 87d8f4c Compare June 25, 2024 18:25

lann closed this Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spin Factors #2519

Spin Factors #2519

lann commented May 20, 2024 •

edited

Loading

rylev Jun 4, 2024

rylev Jun 10, 2024

lann Jun 10, 2024

lann Jun 12, 2024

rylev Jun 17, 2024

lann Jun 17, 2024

lann commented Jun 25, 2024

	.context("missing component allowed hosts")?;
	.with_context(\|\| format!("missing allowed outbound hosts configuration for component {}", ctx.app_component().id()))?;

Spin Factors #2519

Spin Factors #2519

Conversation

lann commented May 20, 2024 • edited Loading

rylev Jun 4, 2024

Choose a reason for hiding this comment

rylev Jun 10, 2024

Choose a reason for hiding this comment

lann Jun 10, 2024

Choose a reason for hiding this comment

lann Jun 12, 2024

Choose a reason for hiding this comment

rylev Jun 17, 2024

Choose a reason for hiding this comment

lann Jun 17, 2024

Choose a reason for hiding this comment

lann commented Jun 25, 2024

lann commented May 20, 2024 •

edited

Loading