factors: Make Factor::configure_app required

Signed-off-by: Lann Martin <[email protected]>

Author: lann

crates/factor-wasi/src/lib.rs

@@ -70,6 +70,13 @@ impl Factor for WasiFactor {
         Ok(())
     }
 
+    fn configure_app<T: RuntimeFactors>(
+        &self,
+        _ctx: spin_factors::ConfigureAppContext<T, Self>,
+    ) -> anyhow::Result<Self::AppState> {
+        Ok(())
+    }
+
     fn prepare<T: RuntimeFactors>(
         ctx: PrepareContext<Self>,
         _builders: &mut InstanceBuilders<T>,

crates/factor-wasi/src/preview1.rs

@@ -15,6 +15,13 @@ impl Factor for WasiPreview1Factor {
         ctx.link_module_bindings(wasmtime_wasi::preview1::add_to_linker_async)
     }
 
+    fn configure_app<T: RuntimeFactors>(
+        &self,
+        _ctx: spin_factors::ConfigureAppContext<T, Self>,
+    ) -> anyhow::Result<Self::AppState> {
+        Ok(())
+    }
+
     fn prepare<T: RuntimeFactors>(
         _ctx: spin_factors::PrepareContext<Self>,
         _builders: &mut spin_factors::InstanceBuilders<T>,

crates/factors/src/factor.rs

@@ -10,7 +10,7 @@ use crate::{
 pub trait Factor: Any + Sized {
     type RuntimeConfig: FactorRuntimeConfig;
 
-    type AppState: Default;
+    type AppState;
 
     type InstanceBuilder: FactorInstanceBuilder;
 
@@ -29,10 +29,7 @@ pub trait Factor: Any + Sized {
     fn configure_app<T: RuntimeFactors>(
         &self,
         ctx: ConfigureAppContext<T, Self>,
-    ) -> anyhow::Result<Self::AppState> {
-        _ = ctx;
-        Ok(Default::default())
-    }
+    ) -> anyhow::Result<Self::AppState>;
 
     fn prepare<T: RuntimeFactors>(
         ctx: PrepareContext<Self>,