Add back LLVM exception for release 3.1 #570
Conversation
src/exceptions/LLVM-exception.xml
Outdated
| <notes>This exception was created specifically to be used with Apache-2.0</notes> | ||
| <titleText> | ||
| <p> | ||
| <optional>---- </optional>LLVM Exceptions to the Apache 2.0 License<optional> ----</optional> |
There was a problem hiding this comment.
I'd rather have the dashes inside an empty <alt> (see previous discussion here and here), because I see the dashes as header markup. I'd much rather they not be part of our canonical HTML, and instead would rather use <h1> or other canonical HTML markup for “this is a header”. We don't have “this is a header” markup in our XML schema yet, but I'd still rather not have these dashes be a part of the canonical HTML we display under spdx.org/licenses/.
There was a problem hiding this comment.
leaving as optional - we can update to later if need be, but this is not substantive and the dashes are taken from the email confirming the new exception, which is not yet showing up in the source repo. We'll update the URL when that hits and can review this then.
There was a problem hiding this comment.
leaving as optional - we can update to later if need be, but this is not substantive…
That's exactly why I prefer <alt>. Why should we have an opinion on the number of dashes?
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
|
This PR has been rebased and updated to comply with the schema changes in pull request #452 |
updated full name as per feedback from LLVM
|
got confirmation from LLVM project as to identifier |
This was temporarily removed from the 3.0 release. To be added once issue #541 is resolved.
Signed-off-by: Gary O'Neall [email protected]