Skip to content

New Exception: LLVM exception #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jlovejoy opened this issue Dec 21, 2017 · 8 comments
Closed

New Exception: LLVM exception #541

jlovejoy opened this issue Dec 21, 2017 · 8 comments
Assignees
@jlovejoy
Labels
new license/exception: Accepted new license/exception request
Milestone
3.1 release

Comments

@jlovejoy
Copy link
Member

pending feedback from LLVM people (sent email to Chris Lattner, et al)
@jlovejoy jlovejoy added this to the Immediate Release - 2.7 milestone Dec 21, 2017
@jlovejoy jlovejoy self-assigned this Dec 21, 2017
@jlovejoy jlovejoy changed the title update LLVM name / identifier New Exception: LLVM exception Dec 27, 2017
@jlovejoy
Copy link
Member Author

moving to 3.1 release for end of Jan due to not hearing back from LLVM yet on name / short identifier

@wking
Copy link
Contributor

wking commented Dec 27, 2017

Does that mean we should temporarily remove src/exceptions/LLVM-exception.xml (originally added in a510984)?

@jlovejoy
Copy link
Member Author

yes, @goneall is taking care of that

@goneall goneall mentioned this issue Dec 27, 2017
Merged
@goneall
Copy link
Member

goneall commented Dec 27, 2017

Deleted LLVM for the 3.0 release and added pull request #570 to add it back in once the LLVM issues are resolved.

@jlovejoy
Copy link
Member Author

merged PR, issue resolved

@wking
Copy link
Contributor

wking commented Mar 22, 2018

merged PR, issue resolved

I still have an issue with the PR, but it's not actually merged yet. Do we want to re-open this issue until the PR lands? I'm also fine just using the PR to track, without keeping the issue open.

@jlovejoy
Copy link
Member Author

I can only click on things so quickly... obviously not as quick as you are at reading new comments!
response in PR... ;)

@wking
Copy link
Contributor

wking commented Mar 22, 2018

I can only click on things so quickly... obviously not as quick as you are at reading new comments!

You can always merge the PR first, and then close the issue with “merged PR” ;). But in this case, we can say the issue was closed because the PR is a sufficient placeholder (which works regardless of whether the PR is open or closed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlovejoy jlovejoy

Labels
new license/exception: Accepted new license/exception request
Projects
None yet
Milestone
3.1 release
Development

No branches or pull requests
3 participants
@wking @goneall @jlovejoy