.travis.yml: Add gulp validation #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding: $ gulp done [20:20:25] Using gulpfile .../license-list-XML/gulpfile.js [20:20:25] Task 'default' is not in your gulpfile [20:20:25] Please check the documentation for proper gulpfile formatting $ echo $? 1
These were committed in 378fe01 (Update all source files to the new XML format and add in the tools from the schemadev branch, 2017-10-17), but they are redundant. The validateall call is redundant when you run the 'validate' task (which has its own validateall call). And the console.log('done') prints done, when it would be better to have validateall print a summary.
The output looks like: [20:28:32] validation complete 362 passed, 1 failed
|
And I've updated the schema with |
wking
force-pushed
the
travis-gulp-tests
branch
from
47fec13 to
d413dd1
Compare
This was referenced Dec 16, 2017
wking
force-pushed
the
travis-gulp-tests
branch
from
d413dd1 to
4cb164a
Compare
goneall
approved these changes
Dec 16, 2017
There was a problem hiding this comment.
Overall, changes look good.
Enabling the gulp testing in travis sounds like a good idea - more efficient then invoking the Java application. Still would like to merge #513 into the same travis-ci script. Will rebase after this merge.
wking
force-pushed
the
travis-gulp-tests
branch
from
4cb164a to
3ddcfc9
Compare
Docs for 'npm test' [1]: > This runs a package's "test" script, if one was provided. This is the default way to run npm tests [2], so this commit adds support for it. [1]: https://docs.npmjs.com/cli/test [2]: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Default-Build-Script
With a .travis.yml based on [1,2], using their default 'npm test' script [3]. [1]: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions [2]: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Using-Gulp [3]: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Default-Build-Script
The spec for 'use' is in [1]. [1]: https://www.w3.org/TR/xmlschema11-1/#declare-attribute
Avoid:
$ npm test
...
[21:00:01] File ./src/ISC.xml at line 9 Element '{http://www.spdx.org/license}alt': The attribute 'name' is required but missing.
...
|
I'm going to merge this so that I can run the license tests again. I'll submit a separate PR for issue #520 |
This was referenced Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the individual pivots in the commit messages, but this pull requests gets automatic schema validation to avoid issues like #517
(which it fixes).The tests aren't as extensive as those in #513. I think we want that sort of XML-template vs. known good/bad sample testing soon, but filling in gulp-based tests seems like something we want as well, and it's easier to implement.
Fixes #518.