Skip to content

CDLA-Sharing-1.0 Parsing Error #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goneall opened this issue Dec 16, 2017 · 8 comments
Closed

CDLA-Sharing-1.0 Parsing Error #517

goneall opened this issue Dec 16, 2017 · 8 comments

Comments

@goneall
Copy link
Member

goneall commented Dec 16, 2017

Following is an XML schema validation error reported when generating the license list data:

Parsing error in XML file CDLA-Sharing-1.0.xml at line 170, column 23:cvc-complex-type.2.4.a: Invalid content was found starting with element 'bullet'. One of '{"http://www.spdx.org/license":item, "http://www.spdx.org/license":list}' is expected., Skipping file CDLA-Sharing-1.0.xml

@wking
Copy link
Contributor

wking commented Dec 16, 2017

Fix in flight with #519.

@zvr
Copy link
Member

zvr commented Dec 16, 2017

The bug is in the data, and is not correctly fixed.
There is a nested list, but it has no items.
The fix #519 deletes the list element instead of adding them.
I'll provide a fix later in the weekend.

@zvr zvr self-assigned this Dec 16, 2017
@wking
Copy link
Contributor

wking commented Dec 16, 2017

The fix #519 deletes the list element instead of adding them.

Yup, see here about why I went that way.

@goneall
Copy link
Member Author

goneall commented Dec 16, 2017

@wking Do you want to move this fix to its own PR? I can then merge the other changes in #519 . @zvr alternatively, if you agree with the changes in the PR I can merge with this fix as well.

@wking
Copy link
Contributor

wking commented Dec 16, 2017

#519's tests won't pass without some fix. I think we should land #519 as it stands, and if @zvr wants he can file a follow-up PR with a <list> and items.

@wking
Copy link
Contributor

wking commented Dec 16, 2017

Checking upstream, they do use a list with item blocks, so I now agree with @zvr on the intended styling. It will take me a bit before I can update #519, so I'm still fine landing the update as follow-up work if you want to land #519 as it stands. Or I should be able to file the update by tomorrow.

@zvr
Copy link
Member

zvr commented Dec 17, 2017

Submitted #521 to fix this

@zvr zvr removed their assignment Dec 17, 2017
@goneall
Copy link
Member Author

goneall commented Dec 18, 2017

Confirmed fixed

@goneall goneall closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants