Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize Gantry #10

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Containerize Gantry #10

merged 9 commits into from
Mar 4, 2024

Conversation

cmelone
Copy link
Collaborator

@cmelone cmelone commented Feb 15, 2024

Added a Dockerfile and some docs about how to run the app. Also moved away from using Spack to handle dependencies as we can use a lightweight/distroless container that allows for a small image size when installing via pip.

@cmelone cmelone added docs Improvements or additions to documentation config Modifications to App Configuration dependencies Modifications to a Dependency File labels Feb 15, 2024
@cmelone cmelone mentioned this pull request Feb 15, 2024
2 tasks
@cmelone cmelone self-assigned this Feb 16, 2024
@cmelone cmelone requested a review from alecbcs February 16, 2024 19:32
@alecbcs
Copy link
Member

alecbcs commented Feb 21, 2024

If possible it'd be nice to keep the Spack environment in the repo for development purposes.

@cmelone
Copy link
Collaborator Author

cmelone commented Feb 21, 2024

Happy to do that, I'll put it back in

@cmelone
Copy link
Collaborator Author

cmelone commented Feb 22, 2024

I put the environment file back in, but I prefer leaving the auto-activation out of .envrc for now as I'm not using Spack in my own environment atm

Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few quick suggestions.

Dockerfile Outdated Show resolved Hide resolved
.envrc Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@cmelone cmelone requested a review from alecbcs February 22, 2024 22:53
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alecbcs alecbcs merged commit 475e9dc into develop Mar 4, 2024
3 checks passed
@alecbcs alecbcs deleted the add/containerize branch March 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Modifications to App Configuration dependencies Modifications to a Dependency File docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants