-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize Gantry #10
Conversation
If possible it'd be nice to keep the Spack environment in the repo for development purposes. |
Happy to do that, I'll put it back in |
I put the environment file back in, but I prefer leaving the auto-activation out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few quick suggestions.
d271996
to
f546562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Added a Dockerfile and some docs about how to run the app. Also moved away from using Spack to handle dependencies as we can use a lightweight/distroless container that allows for a small image size when installing via pip.