Add tests and fixes for the Collection API #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelone
added
config
cmelone
changed the title
cmelone
force-pushed
the
add/collection-tests-fixes
branch
from
d397143
to
1613a48
Compare
alecbcs
reviewed
Feb 22, 2024
cmelone
force-pushed
the
add/collection-tests-fixes
branch
from
5bb593d
to
0b62d35
Compare
cmelone
commented
Feb 26, 2024
alecbcs
previously approved these changes
Mar 4, 2024
they were not being inserted anyways
previously, we would rely on `lastrowid` to provide the pk of the inserted row, but since we're using `INSERT OR IGNORE`, we ran the risk of reusing an old `lastrowid` entry. Now, we will only use it if we've confirmed a row was inserted due to the statement.
…omodate test mocking
cmelone
force-pushed
the
add/collection-tests-fixes
branch
from
3d26a90
to
837ba54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some tests to handle calls to the
fetch_jobandfetch_nodefunction. There's a mix of integration and unit tests here.Because a
POSTrequest to/v1/collectwill return 200 immediately and continue the collection in the background, I decided the best way to perform the tests was directly calling thefetch*functions.In the course of writing this PR, I also fixed a couple bugs in the collection API