Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3664: Testing changes for numpy 2.0 compatibility #8718

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tapastro
Copy link
Contributor

Resolves JP-3664

Closes #8580

This draft exists to remove jwst's upper pin on numpy, as well as provides a spot to test changes to coron3 unit tests that appear to be incompatible with np2.0.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro requested a review from a team as a code owner August 21, 2024 20:17
@tapastro tapastro marked this pull request as draft August 21, 2024 20:17
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (dc2ce65) to head (7784bb9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8718   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files         377      377           
  Lines       38836    38836           
=======================================
  Hits        23996    23996           
  Misses      14840    14840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the jp-3664-np2p0 branch 3 times, most recently from 61f372c to bcba8a3 Compare September 17, 2024 19:34
@tapastro tapastro changed the title WIP JP-3664: Testing changes for numpy 2.0 compatibility JP-3664: Testing changes for numpy 2.0 compatibility Sep 20, 2024
@melanieclarke
Copy link
Collaborator

#8812 fixed most of the coron unit tests with numpy 2, but there's still one check that's barely out of spec on the Linux tests.

I think changing these lines to atol=1e-4, rtol=1e-5 should work:

npt.assert_allclose(aligned, truth_aligned, atol=1e-5)
npt.assert_allclose(shifts, truth_shifts, atol=1e-5)

Comment on lines +126 to +127
- Remove upper pin on ``numpy`` [#8718]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Remove upper pin on ``numpy`` [#8718]

now that #8671 is merged (switching change log handling to towncrier) this change log entry should be a file in changes/ instead:

echo "Remove upper pin on ``numpy``" > changes/8718.general.rst

(new PRs will include instructions on how to do this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWST issues with numpy 2.0
4 participants