-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3664: Testing changes for numpy 2.0 compatibility #8718
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8718 +/- ##
=======================================
Coverage 61.78% 61.78%
=======================================
Files 377 377
Lines 38836 38836
=======================================
Hits 23996 23996
Misses 14840 14840 ☔ View full report in Codecov by Sentry. |
61f372c
to
bcba8a3
Compare
f90c0c6
to
37bab62
Compare
#8812 fixed most of the coron unit tests with numpy 2, but there's still one check that's barely out of spec on the Linux tests. I think changing these lines to atol=1e-4, rtol=1e-5 should work: jwst/jwst/coron/tests/test_coron.py Lines 144 to 145 in 217d660
|
- Remove upper pin on ``numpy`` [#8718] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove upper pin on ``numpy`` [#8718] |
now that #8671 is merged (switching change log handling to towncrier
) this change log entry should be a file in changes/
instead:
echo "Remove upper pin on ``numpy``" > changes/8718.general.rst
(new PRs will include instructions on how to do this)
Resolves JP-3664
Closes #8580
This draft exists to remove jwst's upper pin on numpy, as well as provides a spot to test changes to coron3 unit tests that appear to be incompatible with np2.0.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR