Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Coron3 fit update and unpin numpy #8799

Closed
wants to merge 6 commits into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 17, 2024

The same changes as #8717
and removing the numpy upper pin as the only remaining failure (seen in #8718) is with the coron tests (regression tests have not yet been run).

Resolves JP-nnnn

Closes #

This PR addresses ...

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@braingram
Copy link
Collaborator Author

Test showed failures remain for numpy 2.x with changes in #8717

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.76%. Comparing base (9f82b52) to head (6fdaacb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8799      +/-   ##
==========================================
+ Coverage   60.75%   61.76%   +1.01%     
==========================================
  Files         375      377       +2     
  Lines       38367    38743     +376     
==========================================
+ Hits        23308    23929     +621     
+ Misses      15059    14814     -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant