Introduce SearchState and clean up SearchMoviesVC #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| struct SearchState: Equatable { | ||
| var selectedGenres: [Genre] = [] | ||
| var searchQuery: String = "" | ||
| var currentPage: Int = 1 |
There was a problem hiding this comment.
There is a very subtle bug that I can't figure out right now.
Here are steps to reproduce:
- Enter the search tab. The "Discover Movies" List is being displayed. When you scroll to the bottom, the last movie currently is "Important Police Shit", which is on page 3.
- Re-run the app and search for something that has more than 3 pages (a single letter is usually good)
- Scroll down until you reach a page greater than 3.
- Delete the search term
- Scroll down.
Expected: Page 3 is loaded and the last movie is the same as before (e.g. "Important Police Shit")
Actual: Page 3 is never loaded.
My intuition here is that because currentPage and totalResults is shared between the search and discover request, there is some sort of problem. I have to sleep on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation for #138 and introduces a
SearchStateand cleans upSearchMovieViewController