Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update Search UI #138

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

WIP: Update Search UI #138

wants to merge 11 commits into from

Conversation

fbernutz
Copy link
Member

@fbernutz fbernutz commented Feb 1, 2020 •
edited
Loading

Description

Introduce a new layout for search.

Use SearchTokens to search for:

  • movie genres
  • people
  • rating

new-search

Current state of implementation:

🖼 Screenshots

  • Todo

Checklist

  • Update README.md, if necessary
    (e.g. when adding a new dependency, updating Swift Version, adding new language support)
  • Add an entry (formatted like the others) on Upcoming Release in CHANGELOG.md

Accessibility

  • Add Accessibility Features, like accessibilityLabels or accessibilityValues
  • Test new feature with Dynamic Type
  • Test new feature with Voice Over

@fbernutz fbernutz mentioned this pull request Jun 29, 2020
Merged
@fbernutz
Merge branch 'master' into search-ui
8407b1d 
# Conflicts:
#	Cineaste.xcodeproj/project.pbxproj
#	Cineaste/ReSwift/AppState.swift
#	Cineaste/ReSwift/Reducer/SearchReducer.swift
#	Cineaste/ReSwift/Thunks/SearchThunks.swift
#	Cineaste/ViewController/SearchMovies/SearchMovieDataSource.swift
#	Cineaste/ViewController/SearchMovies/SearchMoviesViewController+SearchController.swift
#	Cineaste/ViewController/SearchMovies/SearchMoviesViewController+UITableView.swift
#	Cineaste/ViewController/SearchMovies/SearchMoviesViewController.swift
#	CineasteTests/SearchReducerTests.swift
@fbernutz
Merge branch 'master' into search-ui
4cae588 
# Conflicts:
#	Cineaste.xcodeproj/project.pbxproj
@fbernutz
Fix Pacakge Versions
3b3773c
@fbernutz
Merge branch 'master' into search-ui
b100982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbernutz @xavierLowmiller