Skip to content

Commit

Permalink
chore: Bump Go version (#50)
Browse files Browse the repository at this point in the history
Apart from changing the Go version to 1.21.5 everywhere, there was
some other breakage/weirdness, which I've fixed in this patch itself.

Code changes:

- For embedded fields, between Go 1.20.12 and Go 1.21.0 there was
  a change where the position (previously wrong) of the defining
  identifier was changed to point to the correct location.

  However, there was another mistake in using the parent node
  location (perhaps intentional) when entering the location into a map,
  causing a mismatch and preventing embedded fields from getting picked
  up properly. I've changed the code to use the correct location when
  inserting into the map.

- We use to track an `inlineCount` value based on the scope structure
  seen. However, for some reason, that's not actually cross-platform.
  So I've replaced it with a line+column pair in the source.

Test changes:

- Add build tag for macOS that only had a Linux tag, so that -update-snapshots
  returns the same results on Linux (in CI) and macOS.
  • Loading branch information
varungandhi-src authored Jan 5, 2024
1 parent 3f63f66 commit 095362e
Show file tree
Hide file tree
Showing 28 changed files with 122 additions and 116 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [ "1.19.8" ]
go-version: [ "1.21.5" ]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
golang 1.19.8
golang 1.21.5
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FROM golang:1.20.3@sha256:bcc311ec9655c350df3899611fdf134806f97a3e3b2c06c2b5c0696428503814
FROM golang:1.21.5@sha256:135ba6c2ae2a9a022f53f3eee24ef213bc62e876811cd9582b91045168206873

COPY scip-go /usr/bin/
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/sourcegraph/scip-go

go 1.19
go 1.21

require (
github.com/efritz/pentimento v0.0.0-20190429011147-ade47d831101
Expand Down
3 changes: 3 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5
github.com/aymerick/raymond v2.0.3-0.20180322193309-b565731e1464+incompatible/go.mod h1:osfaiScAUVup+UC9Nfq76eWqDhXlp+4UYaA8uhTBO6g=
github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
github.com/benbjohnson/clock v1.3.0 h1:ip6w0uFQkncKQ979AypyG0ER7mqUSBdKLOgAle/AT8A=
github.com/benbjohnson/clock v1.3.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
github.com/bufbuild/buf v1.4.0 h1:GqE3a8CMmcFvWPzuY3Mahf9Kf3S9XgZ/ORpfYFzO+90=
github.com/bufbuild/buf v1.4.0/go.mod h1:mwHG7klTHnX+rM/ym8LXGl7vYpVmnwT96xWoRB4H5QI=
github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
Expand Down Expand Up @@ -149,9 +150,11 @@ github.com/google/go-cmp v0.5.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
github.com/google/go-cmp v0.5.3/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/google/go-cmp v0.5.8 h1:e6P7q2lk1O+qJJb4BtCQXlK8vWEO8V1ZeuEdJNOqZyg=
github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
github.com/google/gofuzz v1.1.0 h1:Hsa8mG0dQ46ij8Sl2AYJDUv1oA9/d6Vk+3LG99Oe02g=
github.com/google/gofuzz v1.1.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
github.com/google/pprof v0.0.0-20211214055906-6f57359322fd h1:1FjCyPC+syAzJ5/2S8fqdZK1R22vvA0J7JZKcuOIQ7Y=
github.com/google/pprof v0.0.0-20211214055906-6f57359322fd/go.mod h1:KgnwoLYCZ8IQu3XUZ8Nc/bM9CCZFOyjUNOSygVozoDg=
github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
Expand Down
2 changes: 1 addition & 1 deletion internal/index/scip_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestSnapshots(t *testing.T) {
ModuleRoot: inputDirectory,
ModuleVersion: "0.1.test",
ModulePath: "sg/" + filepath.Base(inputDirectory),
GoStdlibVersion: "go1.19",
GoStdlibVersion: "go1.21",
})
if err != nil {
t.Fatal(err)
Expand Down
2 changes: 1 addition & 1 deletion internal/loader/stdlib.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// THIS FILE IS GENERATED. SEE ./scripts/gen_std_lib.sh
// Generated by: go version go1.19.8 linux/amd64
// Generated by: go version go1.21.5 darwin/arm64
package loader

var contained = struct{}{}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build !linux
// +build !linux
//go:build !linux && !darwin
// +build !linux,!darwin

// From https://github.com/moby/moby/blob/master/libnetwork/osl/sandbox_unsupported.go

Expand Down
26 changes: 13 additions & 13 deletions internal/testdata/snapshots/output/embedded/embedded.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,31 @@

import (
"fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/
"os/exec"
// ^^^^^^^ reference github.com/golang/go/src go1.19 `os/exec`/
// ^^^^^^^ reference github.com/golang/go/src go1.21 `os/exec`/
)

type osExecCommand struct {
// ^^^^^^^^^^^^^ definition 0.1.test `sg/embedded`/osExecCommand#
// documentation ```go
// documentation ```go
// relationship github.com/golang/go/src go1.19 context/stringer# implementation
// relationship github.com/golang/go/src go1.19 fmt/Stringer# implementation
// relationship github.com/golang/go/src go1.19 runtime/stringer# implementation
// relationship github.com/golang/go/src go1.21 context/stringer# implementation
// relationship github.com/golang/go/src go1.21 fmt/Stringer# implementation
// relationship github.com/golang/go/src go1.21 runtime/stringer# implementation
*exec.Cmd
// ^^^^ reference github.com/golang/go/src go1.19 `os/exec`/
// ^^^^ reference github.com/golang/go/src go1.21 `os/exec`/
// ^^^ definition 0.1.test `sg/embedded`/osExecCommand#Cmd.
// documentation ```go
// ^^^ reference github.com/golang/go/src go1.19 `os/exec`/Cmd#
// ^^^ reference github.com/golang/go/src go1.21 `os/exec`/Cmd#
}

func wrapExecCommand(c *exec.Cmd) {
// ^^^^^^^^^^^^^^^ definition 0.1.test `sg/embedded`/wrapExecCommand().
// documentation ```go
// ^ definition local 0
// ^^^^ reference github.com/golang/go/src go1.19 `os/exec`/
// ^^^ reference github.com/golang/go/src go1.19 `os/exec`/Cmd#
// ^^^^ reference github.com/golang/go/src go1.21 `os/exec`/
// ^^^ reference github.com/golang/go/src go1.21 `os/exec`/Cmd#
_ = &osExecCommand{Cmd: c}
// ^^^^^^^^^^^^^ reference 0.1.test `sg/embedded`/osExecCommand#
// ^^^ reference 0.1.test `sg/embedded`/osExecCommand#Cmd.
Expand Down Expand Up @@ -83,13 +83,13 @@
}

fmt.Printf("> %d\n", o.X)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^ reference github.com/golang/go/src go1.19 fmt/Printf().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^ reference github.com/golang/go/src go1.21 fmt/Printf().
// ^ reference local 1
// ^ reference 0.1.test `sg/embedded`/Inner#X.
fmt.Println(o.Inner.Y)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.19 fmt/Println().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.21 fmt/Println().
// ^ reference local 1
// ^^^^^ reference 0.1.test `sg/embedded`/Outer#Inner.
// ^ reference 0.1.test `sg/embedded`/Inner#Y.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import (
"fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/
"sg/embedded"
// ^^^^^^^^^^^ reference 0.1.test `sg/embedded`/
)
Expand All @@ -25,8 +25,8 @@
// ^^^^^^^ reference 0.1.test `sg/embedded`/RecentCommittersResults#Nodes.Authors.
// ^^^^^ reference 0.1.test `sg/embedded`/RecentCommittersResults#Nodes.Authors.Nodes.
fmt.Println(author.Name)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.19 fmt/Println().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.21 fmt/Println().
// ^^^^^^ reference local 2
// ^^^^ reference 0.1.test `sg/embedded`/RecentCommittersResults#Nodes.Authors.Nodes.Name.
}
Expand Down
12 changes: 6 additions & 6 deletions internal/testdata/snapshots/output/embedded/nested.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
// documentation package embedded

import "net/http"
// ^^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/
// ^^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/

type NestedHandler struct {
// ^^^^^^^^^^^^^ definition 0.1.test `sg/embedded`/NestedHandler#
// documentation ```go
// documentation ```go
// relationship github.com/golang/go/src go1.19 `net/http`/Handler# implementation
// relationship github.com/golang/go/src go1.21 `net/http`/Handler# implementation
http.Handler
// ^^^^ reference github.com/golang/go/src go1.19 `net/http`/
// ^^^^ reference github.com/golang/go/src go1.21 `net/http`/
// ^^^^^^^ definition 0.1.test `sg/embedded`/NestedHandler#Handler.
// documentation ```go
// ^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/Handler#
// ^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/Handler#

// Wow, a great thing for integers
Other int
Expand All @@ -30,10 +30,10 @@
_ = n.Handler.ServeHTTP
// ^ reference local 0
// ^^^^^^^ reference 0.1.test `sg/embedded`/NestedHandler#Handler.
// ^^^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/Handler#ServeHTTP.
// ^^^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/Handler#ServeHTTP.
_ = n.ServeHTTP
// ^ reference local 0
// ^^^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/Handler#ServeHTTP.
// ^^^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/Handler#ServeHTTP.
_ = n.Other
// ^ reference local 0
// ^^^^^ reference 0.1.test `sg/embedded`/NestedHandler#Other.
Expand Down
2 changes: 1 addition & 1 deletion internal/testdata/snapshots/output/embedded/something.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// ^^^^^^^^ reference 0.1.test `sg/embedded`/

import "fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/

type RecentCommittersResults struct {
// ^^^^^^^^^^^^^^^^^^^^^^^ definition 0.1.test `sg/embedded`/RecentCommittersResults#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// documentation generallyeric -> generic for short

import "fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/

func Print[T any](s []T) {
// ^^^^^ definition 0.1.test `sg/generallyeric`/Print().
Expand All @@ -16,8 +16,8 @@
// ^ definition local 2
// ^ reference local 1
fmt.Print(v)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^ reference github.com/golang/go/src go1.19 fmt/Print().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^ reference github.com/golang/go/src go1.21 fmt/Print().
// ^ reference local 2
}
}
Expand Down
6 changes: 3 additions & 3 deletions internal/testdata/snapshots/output/generallyeric/person.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// ^^^^^^^^^^^^^ reference 0.1.test `sg/generallyeric`/

import "fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/

type Person interface {
// ^^^^^^ definition 0.1.test `sg/generallyeric`/Person#
Expand All @@ -25,8 +25,8 @@
// documentation ```go
// relationship 0.1.test `sg/generallyeric`/Person#Work. implementation
fmt.Printf("%s is working\n", w)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^ reference github.com/golang/go/src go1.19 fmt/Printf().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^ reference github.com/golang/go/src go1.21 fmt/Printf().
// ^ reference local 0
}

Expand Down
28 changes: 15 additions & 13 deletions internal/testdata/snapshots/output/impls/remote_impls.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,45 +2,47 @@
// ^^^^^ reference 0.1.test `sg/impls`/

import "net/http"
// ^^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/
// ^^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/

func Something(r http.ResponseWriter) {}
// ^^^^^^^^^ definition 0.1.test `sg/impls`/Something().
// documentation ```go
// ^ definition local 0
// ^^^^ reference github.com/golang/go/src go1.19 `net/http`/
// ^^^^^^^^^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/ResponseWriter#
// ^^^^ reference github.com/golang/go/src go1.21 `net/http`/
// ^^^^^^^^^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/ResponseWriter#

type MyWriter struct{}
// ^^^^^^^^ definition 0.1.test `sg/impls`/MyWriter#
// documentation ```go
// documentation ```go
// relationship github.com/golang/go/src go1.19 `crypto/tls`/transcriptHash# implementation
// relationship github.com/golang/go/src go1.19 `net/http`/ResponseWriter# implementation
// relationship github.com/golang/go/src go1.19 io/Writer# implementation
// relationship github.com/golang/go/src go1.21 `crypto/tls`/transcriptHash# implementation
// relationship github.com/golang/go/src go1.21 `internal/bisect`/Writer# implementation
// relationship github.com/golang/go/src go1.21 `net/http`/ResponseWriter# implementation
// relationship github.com/golang/go/src go1.21 io/Writer# implementation

func (w MyWriter) Header() http.Header { panic("") }
// ^ definition local 1
// ^^^^^^^^ reference 0.1.test `sg/impls`/MyWriter#
// ^^^^^^ definition 0.1.test `sg/impls`/MyWriter#Header().
// documentation ```go
// relationship github.com/golang/go/src go1.19 `net/http`/ResponseWriter#Header. implementation
// ^^^^ reference github.com/golang/go/src go1.19 `net/http`/
// ^^^^^^ reference github.com/golang/go/src go1.19 `net/http`/Header#
// relationship github.com/golang/go/src go1.21 `net/http`/ResponseWriter#Header. implementation
// ^^^^ reference github.com/golang/go/src go1.21 `net/http`/
// ^^^^^^ reference github.com/golang/go/src go1.21 `net/http`/Header#
func (w MyWriter) Write([]byte) (int, error) { panic("") }
// ^ definition local 2
// ^^^^^^^^ reference 0.1.test `sg/impls`/MyWriter#
// ^^^^^ definition 0.1.test `sg/impls`/MyWriter#Write().
// documentation ```go
// relationship github.com/golang/go/src go1.19 `crypto/tls`/transcriptHash#Write. implementation
// relationship github.com/golang/go/src go1.19 `net/http`/ResponseWriter#Write. implementation
// relationship github.com/golang/go/src go1.19 io/Writer#Write. implementation
// relationship github.com/golang/go/src go1.21 `crypto/tls`/transcriptHash#Write. implementation
// relationship github.com/golang/go/src go1.21 `internal/bisect`/Writer#Write. implementation
// relationship github.com/golang/go/src go1.21 `net/http`/ResponseWriter#Write. implementation
// relationship github.com/golang/go/src go1.21 io/Writer#Write. implementation
func (w MyWriter) WriteHeader(statusCode int) { panic("") }
// ^ definition local 3
// ^^^^^^^^ reference 0.1.test `sg/impls`/MyWriter#
// ^^^^^^^^^^^ definition 0.1.test `sg/impls`/MyWriter#WriteHeader().
// documentation ```go
// relationship github.com/golang/go/src go1.19 `net/http`/ResponseWriter#WriteHeader. implementation
// relationship github.com/golang/go/src go1.21 `net/http`/ResponseWriter#WriteHeader. implementation
// ^^^^^^^^^^ definition local 4

func Another() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// ^^^^^^^ reference 0.1.test `sg/initial`/

import "fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/

type MyStruct struct{ f, y int }
// ^^^^^^^^ definition 0.1.test `sg/initial`/MyStruct#
Expand Down Expand Up @@ -31,8 +31,8 @@
// ^^^^^^^^ reference 0.1.test `sg/initial`/MyStruct#
// ^ reference 0.1.test `sg/initial`/MyStruct#f.
fmt.Println(s)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.19 fmt/Println().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.21 fmt/Println().
// ^ reference local 2
}

Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,31 @@
// ^^^^^^^^^^^^ reference 0.1.test `sg/inlinestruct`/

import "context"
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/

func Target() interface {
// ^^^^^^ definition 0.1.test `sg/inlinestruct`/Target().
// documentation ```go
OID(context.Context) (int, error)
// ^^^ definition 0.1.test `sg/inlinestruct`/func:Target:OID().
// documentation ```go
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/Context#
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/Context#
AbbreviatedOID(context.Context) (string, error)
// ^^^^^^^^^^^^^^ definition 0.1.test `sg/inlinestruct`/func:Target:AbbreviatedOID().
// documentation ```go
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/Context#
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/Context#
Commit(context.Context) (string, error)
// ^^^^^^ definition 0.1.test `sg/inlinestruct`/func:Target:Commit().
// documentation ```go
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/Context#
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/Context#
Type(context.Context) (int, error)
// ^^^^ definition 0.1.test `sg/inlinestruct`/func:Target:Type().
// documentation ```go
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/Context#
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/Context#
} {
panic("not implemented")
}
Expand All @@ -40,7 +40,7 @@
x.OID(context.Background())
// ^ reference local 0
// ^^^ reference 0.1.test `sg/inlinestruct`/func:Target:OID().
// ^^^^^^^ reference github.com/golang/go/src go1.19 context/
// ^^^^^^^^^^ reference github.com/golang/go/src go1.19 context/Background().
// ^^^^^^^ reference github.com/golang/go/src go1.21 context/
// ^^^^^^^^^^ reference github.com/golang/go/src go1.21 context/Background().
}

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ^^^^^^^^^^ definition 0.1.test `sg/inlinestruct`/emptyMocks.
// documentation ```go
Code func(p Params) (response *HighlightedCode, aborted bool, err error)
// ^^^^ definition 0.1.test `sg/inlinestruct`/inline-30:Code.
// ^^^^ definition 0.1.test `sg/inlinestruct`/inline-6-5:Code.
// documentation ```go
// ^ definition local 0
// ^^^^^^ reference 0.1.test `sg/inlinestruct`/Params#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import (
"fmt"
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^ reference github.com/golang/go/src go1.21 fmt/

"github.com/dghubble/gologin"
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^ reference github.com/sourcegraph/gologin v1.0.2-0.20181110030308-c6f1b62954d8 `github.com/dghubble/gologin`/
Expand All @@ -14,8 +14,8 @@
// ^^^^^^^^^ definition 0.1.test `sg/replace-directives`/Something().
// documentation ```go
fmt.Println(gologin.DefaultCookieConfig)
// ^^^ reference github.com/golang/go/src go1.19 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.19 fmt/Println().
// ^^^ reference github.com/golang/go/src go1.21 fmt/
// ^^^^^^^ reference github.com/golang/go/src go1.21 fmt/Println().
// ^^^^^^^ reference github.com/sourcegraph/gologin v1.0.2-0.20181110030308-c6f1b62954d8 `github.com/dghubble/gologin`/
// ^^^^^^^^^^^^^^^^^^^ reference github.com/sourcegraph/gologin v1.0.2-0.20181110030308-c6f1b62954d8 `github.com/dghubble/gologin`/DefaultCookieConfig.
}
Expand Down
Loading

0 comments on commit 095362e

Please sign in to comment.