Skip to content

Commit

Permalink
chore: Link issue from TODO (#66)
Browse files Browse the repository at this point in the history
  • Loading branch information
varungandhi-src authored Oct 30, 2023
1 parent 68f8c7b commit 3f63f66
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions internal/implementations/implementations.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,10 @@ func AddImplementationRelationships(pkgs loader.PackageLookup, allPackages loade
// local type -> remote interface
findImplementations(localTypes, remoteInterfaces, symbols)

// TOOD: We should consider what this would even look like?
// I don't think this makes sense the current way that we are emitting
// implementations. You wouldn't even catch these anyways when uploading
// TODO(author: tjdevries, issue: https://github.com/sourcegraph/scip-go/issues/64)
// We should consider what this would even look like?
// I don't think this makes sense the current way that we are emitting
// implementations. You wouldn't even catch these anyways when uploading
// remote type -> local interface
// findImplementations(remoteTypes, localInterfaces, symbols)

Expand Down

0 comments on commit 3f63f66

Please sign in to comment.