Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot, coretasks, url: search_url_callbacks() as a public wrapper #2585

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

bot, coretasks, url: search_url_callbacks() as a public wrapper #2585

wants to merge 3 commits into from
+28 −21

Commits on Dec 9, 2023

  1. bot: search_url_callbacks() is a public shim now 

    Actual implementation lives in a private method that can be called
internally without raising a deprecation warning.
    @dgw
    dgw committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    73b2ac8 View commit details
    Browse the repository at this point in the history

  2. coretasks, url: use private bot.search_url_callbacks() implementation 

    Core/builtin code bypasses the deprecation warning that will start in
Sopel 8.1 this way (the public method isn't being removed until 9.0).
    @dgw
    dgw committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    39ef1b2 View commit details
    Browse the repository at this point in the history

  3. test: bypass deprecation warning in bot.search_url_callbacks() tests

    @dgw
    dgw committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    6b7f64d View commit details
    Browse the repository at this point in the history