Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot, coretasks, url: search_url_callbacks() as a public wrapper #2585

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 11, 2023

Description

Follow-up to #2581, which will let us keep using the deprecated mechanism internally without logging warnings about it, while warning third party plugin authors as expected.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

I don't remember if I ran the linter/tests when making this branch a couple days ago, so I won't check those boxes just yet. 😅 Plenty of time to sort it out, as this will be an 8.1 change.

Actual implementation lives in a private method that can be called
internally without raising a deprecation warning.
Core/builtin code bypasses the deprecation warning that will start in
Sopel 8.1 this way (the public method isn't being removed until 9.0).
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Dec 11, 2023
@dgw dgw added this to the 8.1.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant