Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQL]: Use dependencies with relevant versions in azp template #2845

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Jul 5, 2023

Signed-off-by: Nazarii Hnydyn [email protected]

What I did

  • Increase robustness of CodeQL: use only dependencies with the relevant versions

Why I did it

  • To fix CodeQL compilation failures

How I verified it

  1. Make a PR
  2. Do a push

Details if related

@nazariig
Copy link
Collaborator Author

nazariig commented Jul 5, 2023

@prsunny would you please help to merge?

@nazariig nazariig requested a review from qiluo-msft July 6, 2023 09:19
@nazariig
Copy link
Collaborator Author

nazariig commented Jul 6, 2023

@qiluo-msft / @prsunny just a kind reminder

@nazariig
Copy link
Collaborator Author

nazariig commented Jul 7, 2023

@qiluo-msft / @prsunny this is a blocker for Port Profile Init feature. Would you please help to merge?

@nazariig
Copy link
Collaborator Author

@liushilongbuaa / @xumia just a kind reminder

@nazariig
Copy link
Collaborator Author

@prsunny FYI. You won't see all checks are passing until the PR is merged. This is how CodeQL works.

@prsunny
Copy link
Collaborator

prsunny commented Jul 10, 2023

@theasianpianist for viz

@prsunny prsunny merged commit 776af62 into sonic-net:master Jul 10, 2023
13 of 14 checks passed
qiluo-msft pushed a commit that referenced this pull request Jul 12, 2023
…late. (#2843)

**What I did**
* Increase robustness of `CodeQL`: use only dependencies with the relevant versions

**Why I did it**
* To fix `CodeQL` compilation failures

**How I verified it**
1. Make a PR
2. Do a push

**Details if related**
* Backport from `master`: #2845
* Resolves checker issue: #2821
* Takes effect only after PR is merged
theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 20, 2023
…onic-net#2845)

*[CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#2845)
@prgeor
Copy link
Contributor

prgeor commented Sep 8, 2023

@StormLiangMS can this be cherry-picked to 202305

yxieca pushed a commit that referenced this pull request Sep 12, 2023
…2845)

*[CodeQL]: Use dependencies with relevant versions in azp template. (#2845)
@yxieca
Copy link
Contributor

yxieca commented Sep 12, 2023

@nazariig there is a conflict when cherry-picking back to 202211, can you create a separate PR for 202211 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants