[Chassis]Remove redundant updateFabricPortState #2850
Conversation
kenneth-arista
changed the title
|
Hi @kenneth-arista this change is very much needed - thanks ! |
@judyjoseph Let's defer changes to the poll interval in another PR because we need more information what is an appropriate number. |
|
@judyjoseph or @arlakshm is there an issue with the CodeQL pipeline check? How do I retrigger it? |
|
@kenneth-arista, can you rebase your branch |
|
@kenneth-arista , CodeQL issue is being currently worked-upon. Please check this PR and retrigger the pipeline after the PR is merged. #2845 |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
No commit pushedDate could be found for PR 2850 in repo sonic-net/sonic-swss |
Call to updateFabricPortState in FabricPortsOrch::getFabricPortList() is redundant as FabricPortsOrch::doTask() already calls it. This change helps mitigate the MHz spikes during boot up of the supe as described in sonic-net/sonic-buildimage#15321.
kenneth-arista
force-pushed
the
master-remove-fabric-poll
branch
from
bd2972e
to
cfadcb6
Compare
Call to updateFabricPortState in FabricPortsOrch::getFabricPortList() is redundant as FabricPortsOrch::doTask() already calls it. This change helps mitigate the MHz spikes during boot up of the supe as described in sonic-net/sonic-buildimage#15321.
Call to updateFabricPortState in FabricPortsOrch::getFabricPortList() is redundant as FabricPortsOrch::doTask() already calls it. This change helps mitigate the MHz spikes during boot up of the supe as described in sonic-net/sonic-buildimage#15321.
Call to updateFabricPortState in FabricPortsOrch::getFabricPortList() is redundant as FabricPortsOrch::doTask() already calls it. This change helps mitigate the MHz spikes during boot up of the supe as described in sonic-net/sonic-buildimage#15321.
MSFT ADO: 24534105
What I did
Call to
updateFabricPortStateinFabricPortsOrch::getFabricPortList()is redundant asFabricPortsOrch::doTask()already calls it.This change helps mitigate the MHz spikes during boot up of the supe as described in sonic-net/sonic-buildimage#15321.
Why I did it
To help address sonic-net/sonic-buildimage#15321.
Work item tracking
Microsoft ADO: 24534105
How I verified it
Boot up supe on Voq chassis and query fabric counters.
Details if related