Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405][syncd] Enable bulk api for neighbor entries #1415

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Ndancejic
Copy link
Contributor

SAI 1.11.0 added support for bulk neighbor entries. Adding support for neighbor bulk operations to syncd.

cherry-pick of #1373. which includes the commits below:

commit 57b8e6f (HEAD -> ndancejic202405, dancejic/ndancejic202405, 202405)
Author: Nikola Dancejic [email protected]
Date: Tue May 14 18:23:55 2024 +0000

[syncd] Enable bulk api for neighbor entries

SAI 1.11.0 added support for bulk neighbor entries. Adding support for
neighbor bulk operations to syncd.
* added neighbor entry capability to bulk operations in syncd
* added unit tests for neighbor bulk operations
* added code coverage for neighbor bulk operations

Signed-off-by: Nikola Dancejic <[email protected]>

commit fbe3fc7
Author: Nikola Dancejic [email protected]
Date: Fri May 24 17:57:45 2024 +0000

[syncd] Addressing PR comments #1373

Signed-off-by: Nikola Dancejic <[email protected]>

commit a5b2bbb
Author: Nikola Dancejic [email protected]
Date: Tue May 28 01:16:46 2024 +0000

Adding neighborBulkTest to syncd tests

Signed-off-by: Nikola Dancejic <[email protected]>

@bingwang-ms
Copy link
Contributor

@Ndancejic Can you please check the failure in PR test?

@nazariig
Copy link
Collaborator

nazariig commented Sep 4, 2024

@Ndancejic can you please fix CI errors?

@Ndancejic
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SAI 1.11.0 added support for bulk neighbor entries. Adding support for
neighbor bulk operations to syncd.
* added neighbor entry capability to bulk operations in syncd
* added unit tests for neighbor bulk operations
* added code coverage for neighbor bulk operations

Signed-off-by: Nikola Dancejic <[email protected]>
@prsunny
Copy link
Contributor

prsunny commented Sep 23, 2024

@Ndancejic , can you check the build failure? I thought this was already part of 202405. Lets get this resolved asap.

@Ndancejic
Copy link
Contributor Author

Tested on a version without this change as well, test_pfcwd_shared_egress_acl_table.py is failing even without this. I would be happy to help debug the test issue, but since this change is critical for 202405 and is currently failing other PR tests maybe it would be good to merge since all other tests are passing

@saiarcot895
Copy link
Contributor

Test failure in here is for test_pfcwd_shared_egress_acl_table failing. This is seen starting from a sonic-swss commit (sonic-net/sonic-swss@4f0d40c).

This specific failure is fixing a failure in mux test cases. Because it is a net improvement (mux configuration uses the bulk APIs on 202405 branch, which apparently was missing in sairedis when the branch cutoff happened), I'm approving and force merging this PR.

@saiarcot895 saiarcot895 merged commit b764db3 into sonic-net:202405 Oct 1, 2024
15 of 17 checks passed
@saiarcot895
Copy link
Contributor

@bingwang-ms FYI

@nazariig
Copy link
Collaborator

nazariig commented Oct 4, 2024

@saiarcot895 i see that buildimage is pointing to some strange hash of sairedis instead of latest 202405. Can you please fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants