[syncd] Enable bulk api for neighbor entries

[Ndancejic]

SAI 1.11.0 added support for bulk neighbor entries. Adding support for neighbor bulk operations to syncd.

needed for ado: #25072867

[kcudnik]

looks good, make code coverage and unnitests, and move out from draft then i will review it

[Ndancejic]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Ndancejic]

@kcudnik Could you take a look? not sure what else I need for coverage, but the tests that are failing are common among other PRs out right now

[kcudnik]

not passing tests you can ignore, those are flaky, but you can see that you don't have tests that cover your code, and here is exactly showed where: https://dev.azure.com/mssonic/build/_build/results?buildId=552818&view=codecoverage-tab

[kcudnik]

main::test_bulk_neighbor: Fresh start
Killing syncd
Flushing redis
Starting syncd
Replay BCM56850/bulk_neighbor.rec
terminate called after throwing an instance of 'std::runtime_error'
  what():  :- translate_local_to_redis: failed to translate local RID oid:0x20000000006ee
player BCM56850/bulk_neighbor.rec: exitcode: 134:
FAIL: BCM56850.pl

you can make run tests locally on your dev machine by making "make check" and post when they pass

RID translation is problem that you used RID value of object that was not created previously in script or was not obtained by GET api

[Ndancejic]

main::test_bulk_neighbor: Fresh start
Killing syncd
Flushing redis
Starting syncd
Replay BCM56850/bulk_neighbor.rec
terminate called after throwing an instance of 'std::runtime_error'
  what():  :- translate_local_to_redis: failed to translate local RID oid:0x20000000006ee
player BCM56850/bulk_neighbor.rec: exitcode: 134:
FAIL: BCM56850.pl

you can make run tests locally on your dev machine by making "make check" and post when they pass

RID translation is problem that you used RID value of object that was not created previously in script or was not obtained by GET api

I run into the following error when trying to run autogen.sh: configure.ac:32: error: AM_COND_IF: no such condition "CODE_COVERAGE_ENABLED"

[kcudnik]

you need to install " autoconf-archive" packaged in ubuntu that contains that code coverage sctipt

[Ndancejic]

you need to install " autoconf-archive" packaged in ubuntu that contains that code coverage sctipt

I see, I'll get that set up for next time then. I was able to get the coverage passing in the meantime, so this PR is ready for review/merge

[prsunny]

Kamil, could you please review/signoff?

[Ndancejic]

@kcudnik Coverage and tests are passing in the last commit, could you please review

[Ndancejic]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kcudnik]

@Ndancejic i made big refactor on master, removed a lot of unnecessary code, please resolve conflicts and check build

[Ndancejic]

@kcudnik rebased onto the latest, please take a look and approve if no additional comments

[kcudnik]

./unittest/vslib/test_sai_vs_neighbor.cpp
./unittest/lib/test_sai_redis_neighbor.cpp

those files are no longer needed, interface was refactored, and they are not connected into Makefile, can be removed

[nazariig]

@Ndancejic can you please create a separate cherry-pick to 202405 branch? We see Dual-ToR test failures due to missing implementation

[dprital]

@Ndancejic can you please create a separate cherry-pick to 202405 branch? We see Dual-ToR test failures due to missing implementation

@Ndancejic , Do we have PR for 202405 ?

[Ndancejic]

@dprital @nazariig Created the PR: #1415