Apply custom Si settings via CMIS: SONiC xcvrd platform common changes #384

AnoopKamath · 2023-07-06T02:05:11Z

Description

Add new eeprom register fields related to SI settings
Add set_module_si_settings api to validate and apply SI settings. These settings are parsed from platform json file and replaced with current settings

xcvrd changes: sonic-net/sonic-platform-daemons#385

Motivation and Context

Certain high-speed QSFP_DD, OSFP and QSFP modules require Signal Integrity (SI) settings to match platform media settings in order to achieve link stability, right tunning and optimal performance.

How Has This Been Tested?

Added few debugs and made sure right SI settings were picked up and applied successfully.
Validated all flags and eeprom details

Jul  5 20:45:11.039499 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0x0, state=INSERTED, appl 0 host_lane_count 4 retries=0
Jul  5 20:45:11.106772 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting appl=3
Jul  5 20:45:11.174518 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting host_lanemask=0xf0
Jul  5 20:45:11.310503 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting media_lanemask=0xf0
Jul  5 20:45:11.324864 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: force Datapath reinit
Jul  5 20:45:26.070890 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=DP_DEINIT, appl 3 host_lane_count 4 retries=0
Jul  5 20:45:27.092763 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: DpDeinit duration 1.0 secs, modulePwrUp duration 10.0 secs
Jul  5 20:45:43.478087 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=AP_CONFIGURED, appl 3 host_lane_count 4 retries=0
Jul  5 20:45:51.599654 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=INSERTED, appl 3 host_lane_count 4 retries=0
Jul  5 20:45:51.666621 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting appl=3
Jul  5 20:45:51.731384 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting host_lanemask=0xf0
Jul  5 20:45:51.864526 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Setting media_lanemask=0xf0
Jul  5 20:45:51.886060 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: force Datapath reinit
Jul  5 20:46:04.492551 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=DP_DEINIT, appl 3 host_lane_count 4 retries=0
Jul  5 20:46:05.514641 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: DpDeinit duration 1.0 secs, modulePwrUp duration 10.0 secs
Jul  5 20:46:11.329007 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=AP_CONFIGURED, appl 3 host_lane_count 4 retries=0

Jul  5 20:46:22.432689 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: 400G, lanemask=0xf0, state=DP_INIT, appl 3 host_lane_count 4 retries=0
Jul  5 20:46:22.432707 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Check config first time
Jul  5 20:46:22.440499 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124 SI config is applicable...

Jul  5 20:46:23.201671 sonic ERR pmon#xcvrd[26]: Port15 Anoop FINAL optics_si {'OutputEqPreCursorTargetRx': {'OutputEqPreCursorTargetRx1': 3, 'OutputEqPreCursorTargetRx2': 3, 'OutputEqPreCursorTargetRx3': 3, 'OutputEqPreCursorTargetRx4': 3, 'OutputEqPreCursorTargetRx5': 3, 'OutputEqPreCursorTargetRx6': 3, 'OutputEqPreCursorTargetRx7': 3, 'OutputEqPreCursorTargetRx8': 3}, 'OutputEqPostCursorTargetRx': {'OutputEqPostCursorTargetRx1': 0, 'OutputEqPostCursorTargetRx2': 0, 'OutputEqPostCursorTargetRx3': 0, 'OutputEqPostCursorTargetRx4': 0, 'OutputEqPostCursorTargetRx5': 0, 'OutputEqPostCursorTargetRx6': 0, 'OutputEqPostCursorTargetRx7': 0, 'OutputEqPostCursorTargetRx8': 0}, 'OutputAmplitudeTargetRx': {'OutputAmplitudeTargetRx1': 2, 'OutputAmplitudeTargetRx2': 2, 'OutputAmplitudeTargetRx3': 2, 'OutputAmplitudeTargetRx4': 2, 'OutputAmplitudeTargetRx5': 2, 'OutputAmplitudeTargetRx6': 2, 'OutputAmplitudeTargetRx7': 2, 'OutputAmplitudeTargetRx8': 2}}

Jul  5 20:46:23.201671 sonic NOTICE pmon#xcvrd[26]: CMIS: Ethernet124: Optics SI found. Apply

Jul  5 20:46:23.215364 sonic INFO pmon#supervisord: xcvrd ERROR:sonic_platform_base.sonic_xcvr.api.public.cmis:ANOOP print old SCS: {'AdaptiveInputEqEnableTx': {'AdaptiveInputEqEnableTx1': 1, 'AdaptiveInputEqEnableTx2': 1, 'AdaptiveInputEqEnableTx3': 1, 'AdaptiveInputEqEnableTx4': 1, 'AdaptiveInputEqEnableTx5': 1, 'AdaptiveInputEqEnableTx6': 1, 'AdaptiveInputEqEnableTx7': 1, 'AdaptiveInputEqEnableTx8': 1}, 'AdaptiveInputEqRecalledTx': {'AdaptiveInputEqRecalledTx1': 0, 'AdaptiveInputEqRecalledTx2': 0, 'AdaptiveInputEqRecalledTx3': 0, 'AdaptiveInputEqRecalledTx4': 0, 'AdaptiveInputEqRecalledTx5': 0, 'AdaptiveInputEqRecalledTx6': 0, 'AdaptiveInputEqRecalledTx7': 0, 'AdaptiveInputEqRecalledTx8': 0}, 'FixedInputEqTargetTx': {'FixedInputEqTargetTx1': 3, 'FixedInputEqTargetTx2': 3, 'FixedInputEqTargetTx3': 3, 'FixedInputEqTargetTx4': 3, 'FixedInputEqTargetTx5': 3, 'FixedInputEqTargetTx6': 3, 'FixedInputEqTargetTx7': 3, 'FixedInputEqTargetTx8': 3}, 'CDREnableTx': {'CDREnableTx1': 1, 'CDREnableTx2': 1, 'CDREnableTx3': 1, 'CDREnableTx4': 1, 'CDREnableTx5': 1, 'CDREnableTx6': 1, 'CDREnableTx7': 1, 'CDREnableTx8': 1}, 'CDREnableRx': {'CDREnableRx1': 1, 'CDREnableRx2': 1, 'CDREnableRx3': 1, 'CDREnableRx4': 1, 'CDREnableRx5': 1, 'CDREnableRx6': 1, 'CDREnableRx7': 1, 'CDREnableRx8': 1}, 'OutputEqPreCursorTargetRx': {'OutputEqPreCursorTargetRx1': 3, 'OutputEqPreCursorTargetRx2': 3, 'OutputEqPreCursorTargetRx3': 3, 'OutputEqPreCursorTargetRx4': 3, 'OutputEqPreCursorTargetRx5': 3, 'OutputEqPreCursorTargetRx6': 3, 'OutputEqPreCursorTargetRx7': 3, 'OutputEqPreCursorTargetRx8': 3}, 'OutputEqPostCursorTargetRx': {'OutputEqPostCursorTargetRx1': 0, 'OutputEqPostCursorTargetRx2': 0, 'OutputEqPostCursorTargetRx3': 0, 'OutputEqPostCursorTargetRx4': 0, 'OutputEqPostCursorTargetRx5': 0, 'OutputEqPostCursorTargetRx6': 0, 'OutputEqPostCursorTargetRx7': 0, 'OutputEqPostCursorTargetRx8': 0}, 'OutputAmplitudeTargetRx': {'OutputAmplitudeTargetRx1': 2, 'OutputAmplitudeTargetRx2': 2, 'OutputAmplitudeTargetRx3': 2, 'OutputAmplitudeTargetRx4': 2, 'OutputAmplitudeTargetRx5': 3, 'OutputAmplitudeTargetRx6': 3, 'OutputAmplitudeTargetRx7': 3, 'OutputAmplitudeTargetRx8': 3}}

Jul  5 20:46:23.215518 sonic INFO pmon#supervisord: xcvrd ERROR:sonic_platform_base.sonic_xcvr.api.public.cmis:Anoop optics_dict:{'OutputEqPreCursorTargetRx': {'OutputEqPreCursorTargetRx1': 3, 'OutputEqPreCursorTargetRx2': 3, 'OutputEqPreCursorTargetRx3': 3, 'OutputEqPreCursorTargetRx4': 3, 'OutputEqPreCursorTargetRx5': 3, 'OutputEqPreCursorTargetRx6': 3, 'OutputEqPreCursorTargetRx7': 3, 'OutputEqPreCursorTargetRx8': 3}, 'OutputEqPostCursorTargetRx': {'OutputEqPostCursorTargetRx1': 0, 'OutputEqPostCursorTargetRx2': 0, 'OutputEqPostCursorTargetRx3': 0, 'OutputEqPostCursorTargetRx4': 0, 'OutputEqPostCursorTargetRx5': 0, 'OutputEqPostCursorTargetRx6': 0, 'OutputEqPostCursorTargetRx7': 0, 'OutputEqPostCursorTargetRx8': 0}, 'OutputAmplitudeTargetRx': {'OutputAmplitudeTargetRx1': 2, 'OutputAmplitudeTargetRx2': 2, 'OutputAmplitudeTargetRx3': 2, 'OutputAmplitudeTargetRx4': 2, 'OutputAmplitudeTargetRx5': 2, 'OutputAmplitudeTargetRx6': 2, 'OutputAmplitudeTargetRx7': 2, 'OutputAmplitudeTargetRx8': 2}}

Jul  5 20:46:23.215529 sonic INFO pmon#supervisord: xcvrd ERROR:sonic_platform_base.sonic_xcvr.api.public.cmis:Anoop FINAL writable dict:{'AdaptiveInputEqEnableTx': {'AdaptiveInputEqEnableTx1': 1, 'AdaptiveInputEqEnableTx2': 1, 'AdaptiveInputEqEnableTx3': 1, 'AdaptiveInputEqEnableTx4': 1, 'AdaptiveInputEqEnableTx5': 1, 'AdaptiveInputEqEnableTx6': 1, 'AdaptiveInputEqEnableTx7': 1, 'AdaptiveInputEqEnableTx8': 1}, 'AdaptiveInputEqRecalledTx': {'AdaptiveInputEqRecalledTx1': 0, 'AdaptiveInputEqRecalledTx2': 0, 'AdaptiveInputEqRecalledTx3': 0, 'AdaptiveInputEqRecalledTx4': 0, 'AdaptiveInputEqRecalledTx5': 0, 'AdaptiveInputEqRecalledTx6': 0, 'AdaptiveInputEqRecalledTx7': 0, 'AdaptiveInputEqRecalledTx8': 0}, 'FixedInputEqTargetTx': {'FixedInputEqTargetTx1': 3, 'FixedInputEqTargetTx2': 3, 'FixedInputEqTargetTx3': 3, 'FixedInputEqTargetTx4': 3, 'FixedInputEqTargetTx5': 3, 'FixedInputEqTargetTx6': 3, 'FixedInputEqTargetTx7': 3, 'FixedInputEqTargetTx8': 3}, 'CDREnableTx': {'CDREnableTx1': 1, 'CDREnableTx2': 1, 'CDREnableTx3': 1, 'CDREnableTx4': 1, 'CDREnableTx5': 1, 'CDREnableTx6': 1, 'CDREnableTx7': 1, 'CDREnableTx8': 1}, 'CDREnableRx': {'CDREnableRx1': 1, 'CDREnableRx2': 1, 'CDREnableRx3': 1, 'CDREnableRx4': 1, 'CDREnableRx5': 1, 'CDREnableRx6': 1, 'CDREnableRx7': 1, 'CDREnableRx8': 1}, 'OutputEqPreCursorTargetRx': {'OutputEqPreCursorTargetRx1': 3, 'OutputEqPreCursorTargetRx2': 3, 'OutputEqPreCursorTargetRx3': 3, 'OutputEqPreCursorTargetRx4': 3, 'OutputEqPreCursorTargetRx5': 3, 'OutputEqPreCursorTargetRx6': 3, 'OutputEqPreCursorTargetRx7': 3, 'OutputEqPreCursorTargetRx8': 3}, 'OutputEqPostCursorTargetRx': {'OutputEqPostCursorTargetRx1': 0, 'OutputEqPostCursorTargetRx2': 0, 'OutputEqPostCursorTargetRx3': 0, 'OutputEqPostCursorTargetRx4': 0, 'OutputEqPostCursorTargetRx5': 0, 'OutputEqPostCursorTargetRx6': 0, 'OutputEqPostCursorTargetRx7': 0, 'OutputEqPostCursorTargetRx8': 0}, 'OutputAmplitudeTargetRx': {'OutputAmplitudeTargetRx1': 2, 'OutputAmplitudeTargetRx2': 2, 'OutputAmplitudeTargetRx3': 2, 'OutputAmplitudeTargetRx4': 2, 'OutputAmplitudeTargetRx5': 2, 'OutputAmplitudeTargetRx6': 2, 'OutputAmplitudeTargetRx7': 2, 'OutputAmplitudeTargetRx8': 2}}

Jul  5 20:46:23.365141 sonic INFO pmon#supervisord: xcvrd ERROR:sonic_platform_base.sonic_xcvr.api.public.cmis:ANOOP print new SCS: {'AdaptiveInputEqEnableTx': {'AdaptiveInputEqEnableTx1': 1, 'AdaptiveInputEqEnableTx2': 1, 'AdaptiveInputEqEnableTx3': 1, 'AdaptiveInputEqEnableTx4': 1, 'AdaptiveInputEqEnableTx5': 1, 'AdaptiveInputEqEnableTx6': 1, 'AdaptiveInputEqEnableTx7': 1, 'AdaptiveInputEqEnableTx8': 1}, 'AdaptiveInputEqRecalledTx': {'AdaptiveInputEqRecalledTx1': 0, 'AdaptiveInputEqRecalledTx2': 0, 'AdaptiveInputEqRecalledTx3': 0, 'AdaptiveInputEqRecalledTx4': 0, 'AdaptiveInputEqRecalledTx5': 0, 'AdaptiveInputEqRecalledTx6': 0, 'AdaptiveInputEqRecalledTx7': 0, 'AdaptiveInputEqRecalledTx8': 0}, 'FixedInputEqTargetTx': {'FixedInputEqTargetTx1': 3, 'FixedInputEqTargetTx2': 3, 'FixedInputEqTargetTx3': 3, 'FixedInputEqTargetTx4': 3, 'FixedInputEqTargetTx5': 3, 'FixedInputEqTargetTx6': 3, 'FixedInputEqTargetTx7': 3, 'FixedInputEqTargetTx8': 3}, 'CDREnableTx': {'CDREnableTx1': 1, 'CDREnableTx2': 1, 'CDREnableTx3': 1, 'CDREnableTx4': 1, 'CDREnableTx5': 1, 'CDREnableTx6': 1, 'CDREnableTx7': 1, 'CDREnableTx8': 1}, 'CDREnableRx': {'CDREnableRx1': 1, 'CDREnableRx2': 1, 'CDREnableRx3': 1, 'CDREnableRx4': 1, 'CDREnableRx5': 1, 'CDREnableRx6': 1, 'CDREnableRx7': 1, 'CDREnableRx8': 1}, 'OutputEqPreCursorTargetRx': {'OutputEqPreCursorTargetRx1': 3, 'OutputEqPreCursorTargetRx2': 3, 'OutputEqPreCursorTargetRx3': 3, 'OutputEqPreCursorTargetRx4': 3, 'OutputEqPreCursorTargetRx5': 3, 'OutputEqPreCursorTargetRx6': 3, 'OutputEqPreCursorTargetRx7': 3, 'OutputEqPreCursorTargetRx8': 3}, 'OutputEqPostCursorTargetRx': {'OutputEqPostCursorTargetRx1': 0, 'OutputEqPostCursorTargetRx2': 0, 'OutputEqPostCursorTargetRx3': 0, 'OutputEqPostCursorTargetRx4': 0, 'OutputEqPostCursorTargetRx5': 0, 'OutputEqPostCursorTargetRx6': 0, 'OutputEqPostCursorTargetRx7': 0, 'OutputEqPostCursorTargetRx8': 0}, 'OutputAmplitudeTargetRx': {'OutputAmplitudeTargetRx1': 2, 'OutputAmplitudeTargetRx2': 2, 'OutputAmplitudeTargetRx3': 2, 'OutputAmplitudeTargetRx4': 2, 'OutputAmplitudeTargetRx5': 2, 'OutputAmplitudeTargetRx6': 2, 'OutputAmplitudeTargetRx7': 2, 'OutputAmplitudeTargetRx8': 2}}


root@sonic:/home/cisco# sfputil show eeprom-hexdump -n 10 -p Ethernet124
EEPROM hexdump for port Ethernet124 page 10h
        Lower page 0h
        00000000 18 50 04 06 01 00 00 00  00 00 00 00 00 00 2d 96 |.P............-.|
        00000010 82 00 fa 24 36 fb 00 00  3d 00 20 00 00 00 00 00 |...$6...=. .....|
        00000020 00 00 00 00 00 01 00 5e  03 00 00 00 00 00 00 00 |.......^........|
        00000030 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        00000040 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        00000050 00 00 00 00 00 02 52 00  88 01 51 00 88 01 50 1c |......R...Q...P.|
        00000060 44 11 4f 1c 44 11 4c 15  11 ff 4b 15 11 ff ff 00 |D.O.D.L...K.....|
        00000070 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|

        Upper page 10h
        00000080 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        00000090 00 31 31 31 31 39 39 39  39 ff 00 00 33 33 33 33 |.11119999...3333|
        000000a0 ff ff 33 33 33 33 00 00  00 00 22 22 22 22 00 00 |..3333....""""..|
        000000b0 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        000000c0 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        000000d0 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        000000e0 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        000000f0 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|

root@sonic:/home/cisco# sfputil show eeprom-hexdump -n 11 -p Ethernet124
EEPROM hexdump for port Ethernet124 page 11h
        Lower page 0h
        00000000 18 50 04 06 01 00 00 00  00 00 00 00 00 00 2d 96 |.P............-.|
        00000010 81 f4 fa b3 37 03 00 00  3d 00 20 00 00 00 00 00 |....7...=. .....|
        00000020 00 00 00 00 00 01 00 5e  03 00 00 00 00 00 00 00 |.......^........|
        00000030 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        00000040 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
        00000050 00 00 00 00 00 02 52 00  88 01 51 00 88 01 50 1c |......R...Q...P.|
        00000060 44 11 4f 1c 44 11 4c 15  11 ff 4b 15 11 ff ff 00 |D.O.D.L...K.....|
        00000070 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|

        Upper page 11h
        00000080 44 44 44 44 ff ff ff 00  00 00 00 00 00 00 00 00 |DDDD............|
        00000090 00 00 00 00 00 00 00 00  00 ff 45 6c 37 27 3f 4c |..........El7'?L|
        000000a0 3c 19 3f 8b 39 da 41 28  3a b0 85 ca 81 e2 88 b8 |<.?.9.A(:.......|
        000000b0 84 d0 88 b8 84 d0 88 b8  98 58 3b 21 3e 0a 3f cb |.........X;!>.?.|
        000000c0 3e b2 42 3f 46 b4 3e 52  3d 8f 11 11 11 11 31 31 |>.B?F.>R=.....11|
        000000d0 31 31 39 39 39 39 ff 00  00 33 33 33 33 ff ff 33 |119999...3333..3|
        000000e0 33 33 33 00 00 00 00 22  22 22 22 00 00 00 00 00 |333...."""".....|
        000000f0 11 12 13 14 15 16 17 18  11 12 13 14 15 16 17 18 |................|

Additional Information (Optional)

shivuv · 2023-07-18T00:46:08Z

@prgeor : If there are no comments, please approve.

sonic_platform_base/sonic_xcvr/api/public/cmis.py

sonic_platform_base/sonic_xcvr/mem_maps/public/cmis.py

sonic_platform_base/sonic_xcvr/api/public/cmis.py

Co-authored-by: Prince George <[email protected]>

sonic_platform_base/sonic_xcvr/api/public/cmis.py

prgeor

@AnoopKamath LGTM, approved with minor comments.

AnoopKamath · 2023-08-14T18:03:29Z

@prgeor Can you please help merge this PR or add label for 202205

prgeor · 2023-08-16T18:59:26Z

@StormLiangMS please cherry pick to 202305

mihirpat1 · 2023-08-29T17:44:26Z

@StormLiangMS please cherry pick to 202305

ADO - 24988668

#384) Co-authored-by: Prince George <[email protected]>

sonic-net#384) Co-authored-by: Prince George <[email protected]>

AnoopKamath added 4 commits July 5, 2023 18:54

Validate and apply module SI settings

2c4e89b

Update consts.py

fe4f69a

Update cmis.py

94ac72a

Fix build failures

e274021

This was referenced Jul 12, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform daemon changes sonic-net/sonic-platform-daemons#385

Merged

Create CMIS-custom-SI-settings.md sonic-net/SONiC#1334

Merged

prgeor requested review from mihirpat1 and keboliu July 18, 2023 01:37

prgeor added the CMIS label Jul 18, 2023

keboliu requested a review from Junchao-Mellanox July 18, 2023 03:14

AnoopKamath added 2 commits July 18, 2023 00:30

Merge branch 'master' into master

0cae3ae

Update test_cmis.py

a0e6036

prgeor reviewed Jul 18, 2023

View reviewed changes

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

AnoopKamath added 3 commits July 19, 2023 02:03

Address review comments

7eb1564

Update cmis.py

b52254d

Update consts.py

deed9ef

prgeor reviewed Jul 21, 2023

View reviewed changes

keboliu reviewed Jul 24, 2023

View reviewed changes

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

AnoopKamath added 4 commits July 25, 2023 04:45

Create new APIs

3a0204f

Add get_manufacturer API

d4e628d

Update cmis.py

64e5b90

Update cmis.py

97fbabe

prgeor reviewed Jul 26, 2023

View reviewed changes

AnoopKamath and others added 6 commits July 25, 2023 17:23

Update cmis.py

e7fe3c4

Apply suggestions from code review

858fbb0

Co-authored-by: Prince George <[email protected]>

Update cmis.py

36b5ad7

Update cmis.py

321d589

Update cmis.py

ecb723b

Fix failures identified with mock test

ea1c158

AnoopKamath added 3 commits August 3, 2023 23:52

Update test_cmis.py

22bcabd

Update cmis.py

3dbfbca

Update cmis.py

55fb685

prgeor reviewed Aug 5, 2023

View reviewed changes

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

AnoopKamath added 10 commits August 6, 2023 14:50

Fix nibble write api

4917b2c

Update cmis.py

adf9767

Update test_cmis.py

038bc8c

Remove byte read

9f372e8

Replace RegBitField with RegBitsField

51f1822

Update consts.py

03c57ef

Fix build failure

b1532e7

Update test_cmis.py

a72fb74

Merge branch 'master' into master

7d45bff

Merge branch 'master' into master

9aea964

prgeor reviewed Aug 11, 2023

View reviewed changes

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

prgeor reviewed Aug 11, 2023

View reviewed changes

sonic_platform_base/sonic_xcvr/api/public/cmis.py Outdated Show resolved Hide resolved

prgeor previously approved these changes Aug 11, 2023

View reviewed changes

Update cmis.py

e3c1962

AnoopKamath dismissed prgeor’s stale review via e3c1962 August 11, 2023 19:21

prgeor approved these changes Aug 11, 2023

View reviewed changes

prgeor merged commit ae7049c into sonic-net:master Aug 11, 2023
4 checks passed

prgeor added the Request for 202305 Branch label Aug 16, 2023

StormLiangMS added the Included in 202305 Branch label Sep 3, 2023

StormLiangMS pushed a commit that referenced this pull request Sep 3, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes (

a1a002e

#384) Co-authored-by: Prince George <[email protected]>

tshalvi pushed a commit to tshalvi/sonic-platform-common that referenced this pull request Sep 11, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes (

2b8fef2

sonic-net#384) Co-authored-by: Prince George <[email protected]>

tshalvi mentioned this pull request Sep 11, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform common change… tshalvi/sonic-platform-common#1

Open

noaOrMlnx pushed a commit to noaOrMlnx/sonic-platform-common that referenced this pull request Sep 20, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes (

ddac2d4

sonic-net#384) Co-authored-by: Prince George <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes #384

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes #384

AnoopKamath commented Jul 6, 2023 •

edited

Loading

shivuv commented Jul 18, 2023

prgeor left a comment

AnoopKamath commented Aug 14, 2023

prgeor commented Aug 16, 2023

mihirpat1 commented Aug 29, 2023

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes #384

Apply custom Si settings via CMIS: SONiC xcvrd platform common changes #384

Conversation

AnoopKamath commented Jul 6, 2023 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

shivuv commented Jul 18, 2023

prgeor left a comment

Choose a reason for hiding this comment

AnoopKamath commented Aug 14, 2023

prgeor commented Aug 16, 2023

mihirpat1 commented Aug 29, 2023

AnoopKamath commented Jul 6, 2023 •

edited

Loading