Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Solidus installer CI step to Ruby 3.1 #5884

Merged

Conversation

nvandoorn
Copy link
Contributor

The Solidus installer step of CI is failing because of some Ruby 3.1 syntax so we update from Ruby 3.0 to 3.1.

Note that CI is currently failing related to this issue: puma/puma#3532
This should be resolved upstream relatively soon.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@nvandoorn nvandoorn requested a review from a team as a code owner October 23, 2024 21:47
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 23, 2024
@jarednorman
Copy link
Member

There's still a lot of failing happening...

@nvandoorn
Copy link
Contributor Author

@jarednorman I believe this was last run during the puma issues. I'm about to rebase and repush which should hopefully resolve things.

The Solidus installer step of the CI is failing because of some Ruby 3.1
syntax so we update from Ruby 3.0 to 3.1.

Co-authored-by: An Stewart <[email protected]>
@nvandoorn nvandoorn force-pushed the bump-solidus-installer-ruby-version branch from 97d9a21 to 94ebd90 Compare October 28, 2024 20:38
@nvandoorn nvandoorn mentioned this pull request Oct 29, 2024
3 tasks
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdeyen tvdeyen merged commit 99319d7 into solidusio:main Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants