Render variant shipping category #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
There was a problem hiding this comment.
Looks like a solid change! If you rebase off main your failing specs should re-run without issue now that #5886 is merged :)
nvandoorn
force-pushed
the
5675-show-variant-shipping-category-id
branch
from
74c1a5d
to
032c06b
Compare
|
Thanks @MadelineCollier hope you are well. I've pushed a new revision that's been rebased onto main, however I believe this is still blocked by the "Solidus Installer" step. I've addressed this in another pull request #5884 |
If a variant does not have a shipping category defined, the form will render with the shipping category from the associated product. If you submit the form, the variant will now have the same shipping category as associated the product. We fix this by always rendering the form with the shipping category associated with the variant. Co-authored-by: An Stewart <[email protected]>
nvandoorn
force-pushed
the
5675-show-variant-shipping-category-id
branch
from
032c06b
to
b2ed4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a variant does not have a shipping category defined, the form will render with the shipping category from the associated product. If you submit the form, the variant will now have the same shipping category as associated the product.
We fix this by always rendering the form with the shipping category associated with the variant.
Fixes #5675.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: