fix: ensure ParentProps is declared as a type import

[paularmstrong]

Fixes #1311

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• infrastructure changes
• Other... Please describe:

What is the current behavior?

yarn dlx create-solid
//... (I picked Tailwind + TypeScript)

yarn dev --open

In the console, the following error appears:

Uncaught SyntaxError: The requested module '/_build/node_modules/.vite/deps/solid-js.js?v=0fd153d1' does not provide an export named 'ParentProps' (at ErrorBoundary.tsx:2:49)

The error prevents client-side interaction other than navigation.

Building the application and running production mode does not have the error.

What is the new behavior?

No more syntax error in browser.

I verified this works by manually modifying the code from NPM when creating my application.

Note

This was not reproducible within the solid-start repository. I suspect it has to do with local tsc compiling/configs?

Other information

[changeset-bot]

🦋 Changeset detected

Latest commit: 4d66b4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solidjs/start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[paularmstrong]

It looks like there are some other locations this happens as well. What's the intended process here?

I can work around this by having vite include solid-start:

import { defineConfig } from '@solidjs/start/config';

export default defineConfig({
	optimizeDeps: {
		include: ['@solidjs/start/**/*.tsx'],
	},
});

[ryansolid]

Making it a type import where it should be is always best.

Thanks.

[paularmstrong]

@ryansolid are you open to adding eslint to the project? the @typescript-eslint/consistent-type-imports rule can auto-fix this and prevent regressions.