Merge pull request #1312 from paularmstrong/fix-error-boundary-issue

fix: ensure ParentProps is declared as a type import
solidjs · Feb 7, 2024 · 4b9f236 · 4b9f236
2 parents 20697ed + 4d66b4d
commit 4b9f236
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/.changeset/many-eggs-move.md b/.changeset/many-eggs-move.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Fixed an issue with TypeScript based projects throwing client side errors regarding a type input in the `ErrorBoundary`.wq
diff --git a/packages/start/shared/ErrorBoundary.tsx b/packages/start/shared/ErrorBoundary.tsx
@@ -1,24 +1,13 @@
-import {
-  ErrorBoundary as DefaultErrorBoundary,
-  ParentProps,
-} from "solid-js";
+import { ErrorBoundary as DefaultErrorBoundary, type ParentProps } from "solid-js";
 import { HttpStatusCode } from "./HttpStatusCode";
 import { DevOverlay } from "./dev-overlay";
 
 export function ErrorBoundary(props: ParentProps) {
   if (import.meta.env.DEV) {
-    return (
-      <DevOverlay>
-        {props.children}
-      </DevOverlay>
-    );
+    return <DevOverlay>{props.children}</DevOverlay>;
   }
   return (
-    <DefaultErrorBoundary
-      fallback={(
-        <HttpStatusCode code={500} />
-      )}
-    >
+    <DefaultErrorBoundary fallback={<HttpStatusCode code={500} />}>
       {props.children}
     </DefaultErrorBoundary>
   );