Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History #847

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

History #847

wants to merge 70 commits into from

Conversation

michielbdejong
Copy link
Contributor

No description provided.

@michielbdejong michielbdejong changed the base branch from main to 2023-redesign February 14, 2024 15:01
@michielbdejong michielbdejong marked this pull request as draft February 14, 2024 15:01
@michielbdejong
Copy link
Contributor Author

Need to fix the layout

TallTed
TallTed reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of broken HTML in here. Just one example — make a class="c11"&gt;read-write web of data. — note the missing < to open the anchor, and the incorrectly escaped &gt; to close that opener, and then the complete lack of anchor closure.

history.html Outdated Show resolved Hide resolved
@michielbdejong michielbdejong force-pushed the 2023-redesign branch 2 times, most recently from cbb57a9 to 1d56403 Compare May 2, 2024 07:28
michielbdejong and others added 24 commits May 24, 2024 07:52
@michielbdejong
Download and unzip artifact from https://github.com/solid/solidprojec…
f8c42ca 
…t.org/actions/runs/8885886631/job/24398233370
@michielbdejong
a draft version -> historical content
e3abac2
@michielbdejong
Remove files that will be overwritten by the redesign, but keep the rest
55a7745
@michielbdejong
First version of work delivered by Rajnish, see #823
27f308d
@michielbdejong
No more use for DependaBot in this repo
15b7b84
@michielbdejong
Rajnish work rounds 2 and 3
d2e6b4f
@michielbdejong
linebreaks in readme
f8521ab
@michielbdejong
Update README.md
335d4b1
@michielbdejong
We don't have a newsletter
e43b949
@michielbdejong
Convert all html and css file line endings to LF instead of CRLF, as …
5848fe5 
…recommended for git-handled repos
@michielbdejong
Keep old tagline
2840b16
@michielbdejong
Improvement by @TallTed
a944419
@michielbdejong
Small corrections
2c6ac5d
@michielbdejong @TallTed
improvements by @TallTed
b2014a5 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
27de56f 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
00deed4 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
964d951 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
c637bda 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
5544d39 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
d8781d7 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong @TallTed
improvements by @TallTed
cc59acb 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@michielbdejong
Explain use of file URLs
c939e4f 
For website development
@michielbdejong @TallTed
reword
447dcc7 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@VirginiaBalseiro @csarven @michielbdejong
Refactor Redesign Code (#836)
d35433a 
* WIP: refactor HTML/CSS

Co-authored-by: Sarven Capadisli <[email protected]>

* HTML corrections / alignment for index, about

* consolidate stylesheets, minor fixes

* Update homepage img alt for article

* Minor

* Remark for-developers

* Remark for-organizations

* Add contact possibilities for orgs

* Update pod-provider and research-institution blocks

* borders, minor CSS changes

* Use details for whole video figcaption

* Minor

* CSS fixes, WIP

* Add Terms

* Minor

* Update community

* Use /about

* Add redirects file

* Add some DOAP about Solid Project

* Remove unused reference

* Add ethicsPolicy to Solid CoC

* WIP styles for community page, mobile

* Minor

* CSS fixes

* Adjustments to events details margin/padding

* Padding, lists styles

* Padding

* Update hosted-pod-services listing markup

* Update events markup

* Hide dt in hosted-pod-services

* fix about page file extension, inline widths, image alt text and role

* Adjust font-size in pod providers list

* Update alt/role

* Minor

---------

Co-authored-by: Sarven Capadisli <[email protected]>
@michielbdejong
Copy link
Contributor Author

I rebased on 2023-redesign. The layout of this page still needs some love:
Screenshot 2024-06-11 at 10 24 39

I'm not the right person to work on that though, maybe a frontend developer can have a look?
Will leave this open as a draft PR in case someone wants to pick it up.

@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for musical-sawine-26ffa9 ready!

Name Link
🔨 Latest commit 078c072
🔍 Latest deploy log https://app.netlify.com/sites/musical-sawine-26ffa9/deploys/666c1a4e4250f10008520233
😎 Deploy Preview https://deploy-preview-847--musical-sawine-26ffa9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csarven
Copy link
Member

csarven commented Jun 11, 2024

@TallTed @michielbdejong There were way too many changes to do such that it was easier to push this commit b0247f1 (including "markup, stylesheet, links/references, RDFa, editorial and content changes") instead of making inline suggestions through GitHub's UI. It is a take it or leave it.

@TallTed I've done some minor editorial changes as well as proposing changes mentioned in #840 (comment) as an initial pass I think you should continue to review this article and also perhaps check for accuracy / relevancy. The article still seems like a draft but it can be improved - whether through your and/or others changes (and over time).

@timbl Have a look.

@michielbdejong
Copy link
Contributor Author

rendering is still not great but better than nothing I think:
Screenshot 2024-06-13 at 11 17 23

As a possible improvement, do you think you could center the white rectangle and maybe give it rounded corners, like on the main /about.html page?

Only real rendering bug I see is the aspect ratio of the avatar in the 'More details about this document' view, it's very wide and not very high:
Screenshot 2024-06-13 at 11 20 20

@michielbdejong
Copy link
Contributor Author

Here is that same avatar but in its correct aspect ratio: https://www.w3.org/Press/Stock/Berners-Lee/2001-europaeum-eighth.jpg

Base automatically changed from 2023-redesign to main June 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michielbdejong @csarven @TallTed @VirginiaBalseiro @KyraAssaad @megoth @ewingson