-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update flipcard template #1752
Open
paulovareiro29
wants to merge
9
commits into
next
Choose a base branch
from
fix/flipcard-template-images-alt
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−19
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
84c82d2
fix: improve flipcard template image alt text
paulovareiro29 9e507dd
chore: changeset
paulovareiro29 1c8c779
fix: gradient issue on flipcard, implemented updated flipcard template
paulovareiro29 1a294b1
chore: remove unecessary attribute
paulovareiro29 41ad2d1
chore: update changeset
paulovareiro29 48e1099
chore: update template
paulovareiro29 ccbeb52
Merge branch 'next' of github.com:solid-design-system/solid into fix/…
paulovareiro29 6962004
Merge branch 'next' of github.com:solid-design-system/solid into fix/…
paulovareiro29 552da2c
Merge branch 'next' into fix/flipcard-template-images-alt
mariohamann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@solid-design-system/components': patch | ||
'@solid-design-system/docs': patch | ||
--- | ||
|
||
Fixed gradient issue on flipcard. | ||
Implemented an improved flipcard template version. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need sd-prose if you style everything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not manually forcing any margins on this flipcard, the sd-prose is doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah. I'm just curious, if you could omit e. g.
sd-headline sd-headline--size-lg sd-headline--inverted
when you just havesd-prose sd-prose--inverted
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and using
sd-prose sd-prose--inverted
does not invert thesd-headline
.Should we create a ticket for this?